Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This, however, won't fail if the module happens to include default config that is owned by that module.
Discovered in #1779026: Convert Text Formats to Configuration System, where I try to add a filter format for php.module.
Comment | File | Size | Author |
---|---|---|---|
#1 | i-hate-enable-disable-test.patch | 677 bytes | tim.plunkett |
Comments
Comment #1
tim.plunkettSee attached.
Bumping priority since it blocks the correct fix in #1779026: Convert Text Formats to Configuration System (which is major)
Comment #2
xjmI swear I've made this exact change before, but I can't find the issue. RTBC assuming it passes tests (and @tim.plunkett says it did locally).
Comment #3
xjmComment #4
damiankloip CreditAttribution: damiankloip commentedYeah, when you see it there it does look a bit silly :)
Would any other test using this ever need to optionally add a prefix? I guess not really.
Looks good!
Comment #5
sun@xjm's memory is wrong ;) - this patch reverts our recent change from:
#1850158: Bugged assumption in ModuleTestBase::assertModuleConfig()
That issue essentially introduced the module prefix to fix a range of problems down the line.
Now this issue essentially wants to revert it back to fix different problems down the line. (That said, the issue summary needs to be updated to clarify what exact problems we're facing.)
It might make more sense to mark this as duplicate of aforementioned issue and re-open that one.
Ultimately, we seem to be circling back into the epic #1776830: [META-1] Installation and uninstallation of configuration provided by a module that belongs to another module's API here. We can possibly try to work around the larger problem space, although the fact that we're trying to duct-tape the same test assertion line back and forth within less than a month already tells a tale.
Comment #6
tim.plunkettThis was actually introduced recently, and should just be reverted: #1850158: Bugged assumption in ModuleTestBase::assertModuleConfig()
Comment #7
xjmhttp://i0.kym-cdn.com/photos/images/original/000/001/582/picard-facepalm...