This module forces the picture field on the user, to be set to the default image, configured in the account settings.

By using this module, a user picture is always available to any module/function that handles entities, because the file reference is set as a property on the entity.

Drupal's default behavior is that the code which handles a user entity must check the user_picture_default variable but this is not as flexible, since it does not populate a field with an image etc.

Core: 7.x (developed on 7.17)
Project: http://drupal.org/sandbox/esbenvb/1454252
Version control:
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/esbenvb/1454252.git user_picture_default
cd user_picture_default

NOTE: The sandbox was initially called superior_user_picture_default but the module is now called user_picture_default which is also the desired full project name.

Reviews of other projects

Files: 

Comments

arjkap’s picture

Hi,

Please correct the code line to clone the repository. It is user specific and asks for your password.

The module file has a missing @file directive in line with http://drupal.org/node/1354#files

And you are still using the master branch. You need to shift to a version specific branch according to your module eg. 6.x-1.x or 7.x-1.x . Refer - http://drupal.org/empty-git-master

Very Minor coding standard errors- http://ventral.org/pareview/httpgitdrupalorgsandboxesbenvb1454252git

vineet.osscube’s picture

Manual Review:

There is no hook_uninstall to remove your custom variables from database like: user_picture_default. in admin.inc. Add variable_del() to remove your variable in .install file or SQL delete query.

vineet.osscube’s picture

Issue summary:View changes

Changed description

esbenvb’s picture

#1

The things you mentioned have been fixed - thanks for reply!

#2

The variable is not set in my module, it's a part of user.module.

georgemastro’s picture

Status:Needs review» Needs work
StatusFileSize
new47.17 KB

Please fix your branches.
See attached image. You should delete master branch.

esbenvb’s picture

#4 The master branch has been deleted

esbenvb’s picture

Status:Needs work» Needs review
Issue tags:+PAReview: review bonus

Reviews of other projects

esbenvb’s picture

Issue summary:View changes

fixed git info

klausi’s picture

Status:Needs review» Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1873980
Project 2: http://drupal.org/node/1870738
Project 3: http://drupal.org/node/1380540

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

esbenvb’s picture

klausi: Sorry about that, what you say makes perfect sense, my bad :)

esbenvb’s picture

Issue summary:View changes

Added list of my reviews