The attached patch corrects a few minor inconsistencies with the use of @link...@endlink in some core code files, specifically,
core/includes/database.inc
core/lib/Drupal/Core/Ajax/ReplaceCommand.php
core/modules/field/field.api.php
core/modules/system/system.api.php

CommentFileSizeAuthor
#12 fix-link-endlink-inconsistencies-1864360-12.patch624 bytesoadaeh
#6 fix-link-endlink-inconsistencies-1864360-6.patch2.42 KBoadaeh
#2 fix-link-endlink-inconsistencies-1864360-2.patch1.72 KBoadaeh
fix-link-endlink-inconsistencies.patch3.27 KBoadaeh

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

By my count, the lines you rewrapped in field.api.php and system.api.php were 80 characters before and do not need rewrapping?

The rest of the patch looks good though, thanks!

oadaeh’s picture

oadaeh commented
Status: Needs work » Needs review
StatusFileSize
new fix-link-endlink-inconsistencies-1864360-2.patch1.72 KB

My editor was telling me they were 81 characters, but I guess it was telling me about the next character, not the current one. I'll have to pay better attention to that.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks! That patch looks great to me.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

Probably some of this should be backported to d7?

oadaeh’s picture

oadaeh commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new fix-link-endlink-inconsistencies-1864360-6.patch2.42 KB

Looks like all of them came from D7 that way. I also found another one.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks! That one additional place you found in d7 -- does it exist in d8 also? If so, we should fix it in d8 before proceeding to d7 (or at least do a follow-up patch after this is committed).

oadaeh’s picture

oadaeh commented

When I found it in D7, I went and checked the D8 version, and it was correct.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Thanks!

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/8ec1f07

David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 8.x-dev
Status: Fixed » Needs work

Actually, the change to includes/ajax.inc needs to go into Drupal 8 too.

oadaeh’s picture

oadaeh commented
Status: Needs work » Needs review
StatusFileSize
new fix-link-endlink-inconsistencies-1864360-12.patch624 bytes

Sorry about that. I thought I got that one.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, fix-link-endlink-inconsistencies-1864360-12.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review

#12: fix-link-endlink-inconsistencies-1864360-12.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

That was some kind of a test bot glitch ("Failed to get list of tests to run" or something like that).

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. I think this issue is done now -- thanks oadaeh!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

oadaeh’s picture

oadaeh commented
Assigned: oadaeh » Unassigned
Issue summary: View changes