Per the API docs the 'has_body' attribute is no longer defined.

Instead, you are supposed to do:node_add_body_field() somewhere in poll.install. In this case, it is not necessary to add a body field; the (erroneous) 'has_body' attribute is FALSE anyway.

So, the fix is to remove that attribute from the array on line 194.

CommentFileSizeAuthor
#4 drupal-poll_delete_has_body_attribute-1863290.patch535 bytesvomiand
PASSED: [[SimpleTest]]: [MySQL] 41,462 pass(es). View
#1 poll_patch_delete_has_body_attribute.patch534 byteswoprrr
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch poll_patch_delete_has_body_attribute.patch. Unable to apply patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

woprrr’s picture

FileSize
534 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch poll_patch_delete_has_body_attribute.patch. Unable to apply patch. See the log in the details link for more information. View

The row is deleted, the installation of a body is not useful here it is sufficient to create a field directly from the interface if needed

woprrr’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, poll_patch_delete_has_body_attribute.patch, failed testing.

vomiand’s picture

Status: Needs work » Needs review
Issue tags: -Novice
FileSize
535 bytes
PASSED: [[SimpleTest]]: [MySQL] 41,462 pass(es). View

Removed the has_body attribute from the array on line 194.

dooug’s picture

dcam’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -

Simple fix. RTBC.

I did find one other instance of 'has_body' in D7. It's in drupalCreateContentType() in drupal_web_test_case.php along with the 'body_label' attribute. I can't imagine that they're required for testing, but I could be wrong. I was thinking it might be a good idea to create a follow up issue to remove them.

David_Rothstein’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

Yeah, a followup for that case in drupalCreateContentType() sounds like a good idea.

  • David_Rothstein committed d479272 on 7.x
    Issue #1863290 by woprrr, vomiand, dcam, vegantriathlete: poll_node_info...
dcam’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.