EntityFieldQuery and Domain Access [#1855298]

This may be a more general thing, but if it is I haven't been able to find the right issue: using EntityFieldQuery.

If I have

  $query = new EntityFieldQuery();
  $result = $query->entityCondition('entity_type', 'node')
  ->propertyCondition('status', 1)
  ->propertyCondition('type', array('blog'))
  ->fieldOrderBy('field_date', 'value', 'desc')
  ->execute();

It works nicely, but for administrators, at least, it doesn't respect domain access settings.

If I use addTag('node_access') it crashes out with "PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'field_data_field_date0.nid' in 'on clause':" etc.

If I remove fieldOrderBy, but keep addTag('node_access') it works and respects domain access settings.

If I try it without Domain Access, but with fieldOrderBy and addTag, it seems to work.

I tried adding

hook_query_entity_field_access_alter(QueryAlterableInterface $query) {
  domain_alter_node_query($query, 'node');
}

and that crashes out with the same PDO error.

Comment	File	Size	Author
#11	1855298-efq-restrict.patch	579 bytes	DeFr
#8	1855298-domain-access-efq.patch	5.14 KB	agentrickard

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

apemantus CreditAttribution: apemantus commented 30 November 2012 at 19:22

Priority:

Normal

» Minor

(The workaround seems to be to avoid EFQ and use db_select instead, which requires a bit more hard work, but doesn't seem to crap out on node_access)

Comment #2

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard commented 30 November 2012 at 21:15

This is a problem only for admins, and it may be that domain_alter_node_query() hasn't kept pace with changes to core EFQ.

What version of Drupal core are you running?

Comment #3

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard commented 30 November 2012 at 21:17

In your pseudo-code from #1, the second argument should be "entity", not "node".

Comment #4

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard commented 30 November 2012 at 21:30

Category:

bug

» support

In the fieldOrderBy(), did you try using the field name without the _field prefix? e.g. This fails for me on core:

  $query = new EntityFieldQuery();
  $result = $query->entityCondition('entity_type', 'node')
  ->propertyCondition('status', 1)
  ->propertyCondition('type', array('article'))
  ->fieldOrderBy('field_data_body', 'value', 'desc')
  ->execute();

But this works:

  $query = new EntityFieldQuery();
  $result = $query->entityCondition('entity_type', 'node')
  ->propertyCondition('status', 1)
  ->propertyCondition('type', array('article'))
  ->fieldOrderBy('body', 'value', 'desc')
  ->execute();

Comment #5

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard commented 30 November 2012 at 21:32

Category:

support

» bug

Hm. Even using "body" the local domain_query function throws an error.

Comment #6

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard commented 30 November 2012 at 21:42

I looked harder at the code in node module, and there are two things here:

1) Your query actually needs to be tagged with "entity_field_access" not "node_access". This is unclear in the documentation, but clear in the comments in node_query_entity_access_alter().

2) DA needs to add the new hook to account for EFQ.