Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have a large number of install profiles as I run Aegir on my local machine and use an install profile for all individual projects, so it can get a little cluttered after a while given that there is no logical sorting of the list.
Additionally, when an install profile changes the human-readable name of a common install profile short_name (Such as pressflow does to the 'default' install profile for Drupal 6) it can be confusing, so it would be nice to show the machine name along side the human readable name.
Patch coming in comment #1.
Comment | File | Size | Author |
---|---|---|---|
#1 | sort_profiles-1853588-1.patch | 768 bytes | Deciphered |
Comments
Comment #1
Deciphered CreditAttribution: Deciphered commentedComment #2
anarcat CreditAttribution: anarcat commentedI like this too, good job.
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedThis patch adds a call to
node_load
, the performance implications of this should be investigated.Comment #4
Steven Jones CreditAttribution: Steven Jones commentedThanks very much for the patch, I've applied the sorting part to 6.x-2.x, but I've not included the part that adds the short name to the list. Please open a separate issue for that, and we can discuss there, I think there's a small performance issue with doing the node load on each profile, and the site form is already super slow.
Comment #5
thedavidmeister CreditAttribution: thedavidmeister commentedheh, can't you get the short_name from hosting_package_instances_load?
That way the performance issue can be handled within hostmaster rather than relying on the core of d6 to do something.
For example, I haven't profiled it but _hosting_package_instances_load() looks like it's screaming to be at least statically cached, if not persistently.
If it was persistently cached you could add all sorts of hostmaster-specific bits and pieces (like the short_name) to the UI without invoking a bunch of node_load()s - which are much slower than they should be in d6 without native, or even contrib, persistent caching of node objects :/
Would anyone be interesting in me opening a ticket for that in parallel to the issue for displaying the short_name, as it seems like in light of this discussion it may (perhaps after a little profiling) help get that nice UI improvement over the line?
Comment #6
Steven Jones CreditAttribution: Steven Jones commented@thedavidmeister please open such a ticket!
Comment #7
thedavidmeister CreditAttribution: thedavidmeister commenteddone - #1875440: static and persistent caching for _hosting_package_instances_load()