It would be great to add the few html5 elements that could fit here. I'm thinking of <i>, <b>, <hr>, <small>, <figure>, <figcaption>, etc. Given that core is xhtml, this may be out of scope, but with html5 happening in theming, it would really help the usefulness of this (already awesomely useful) tool.

[edited to wrap elements in code tags]

CommentFileSizeAuthor
#3 Selection_002.png321.57 KBchrisjlee
#3 Selection_003.png326.17 KBchrisjlee
#2 styleguide-add_html5-1852050-2.patch2.94 KBdead_arm

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Makes sense here.

dead_arm’s picture

dead_arm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new styleguide-add_html5-1852050-2.patch2.94 KB

Patch to add <i>, <b>, <hr>, <small>, <figure>, <figcaption>, <del>, <q>, <s>, <sub>, <sup>, and <u>

chrisjlee’s picture

chrisjlee commented
StatusFileSize
new Selection_003.png326.17 KB
new Selection_002.png321.57 KB

Looks good to me. Tested with bartik.

Before patch is shown on the left as labeled (in the bottom of the images).
After is shown on the right.

dead_arm’s picture

dead_arm
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks for testing this. Committed! http://drupalcode.org/project/styleguide.git/commit/00e8a5f8f53e38f23631...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

[edited to wrap elements in code tags]