In #1774312: Create.js: yay or nay *and*: when?, there was much discussion and broad support for basing inplace editing on VIE and Create.js.

#1824500: In-place editing for Fields has been submitted to the core queue. As we've done with other vendor libraries, I propose we commit these separately in this issue to make patch uploads in that issue smaller and easier to review. Here is just that portion.

Some important notes about the state of these libraries

From #1824500-9: In-place editing for Fields:

We're still working with @bergie to improve Create.js in some areas, that will allow our code to be slightly simplified further/made more consistent. We're also going to work with him to make the builds smaller, but that can definitely be a post-feature freeze thing. After talking to @nod_, the current size is definitely small enough [14KB for VIE+Create, minified and gzipped]... We include the unminified builds of Create and VIE for now, for easier debugging.

From #1824500-26: In-place editing for Fields:

[This] patch includes the VIE.js "core" build and Create.js "editonly" build. I've indicated this as such in the library definitions, but honestly, this may imply that it's not a perfect fit to have these non-complete builds in core/misc, exactly because they're incomplete. That being said, it should be possible to add complementary builds for both that when combined would be equal to the complete build. That will need some upstream work though.

#9 1849526-vie_create_upstream_fixes-9.patch11.8 KBWim Leers
PASSED: [[SimpleTest]]: [MySQL] 48,905 pass(es). View
create.js_.patch187.22 KBeffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 48,768 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


Status: Needs review » Needs work

The last submitted patch, create.js_.patch, failed testing.

effulgentsia’s picture

Status: Needs work » Needs review

create.js_.patch queued for re-testing.

sun’s picture

Assigned: Unassigned » Dries
Status: Needs review » Reviewed & tested by the community

Thanks! Makes sense.

Other issues of this kind are typically assigned to @Dries to sign off, so let's do the same here.

Wim Leers’s picture

Issue tags: +JavaScript, +Spark

Note that according to #1824500-30: In-place editing for Fields, @nod_ (D8 JS maintainer) is in favor of Create.js and VIE.js. I'll ask him to comment here.

nod_’s picture

Yep a big fat +1 from me, see the review linked to above and more importantly the edit code before createjs/VIE was used to really get how much we'd want them :)

webchick’s picture

Category: task » feature

This is a blocker for a feature, so it doesn't make sense to block other features on it. :)

Dries’s picture

Assigned: Dries » Unassigned

This makes sense, and was discussed in other forums too. I'm comfortable with committing this once we are below threshold.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Ok, we're not quite below thresholds, but it's pretty damn close (101 majors, 18 criticals of which 4 are change notices), and I'd like to make sure we get some features committed this week. :) Therefore...

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Title: Add VIE and Create.js libraries to core » Add VIE and Create.js libraries to core (upstream fixes)
Status: Fixed » Reviewed & tested by the community
11.8 KB
PASSED: [[SimpleTest]]: [MySQL] 48,905 pass(es). View

I hope this is the right way to get upstream fixes for 3rd party libs committed. I apologize if it is not.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Hm. Looks like this is a straight-up update of the VIE/Create.js code based on upstream improvements, so committed / pushed to 8.x.

I think in the future, we should get a different issue for this though, ala #1834594: Update dependencies (Symfony and Twig) follow up fixes for Composer, because my guess is this is going to happen A LOT. :)

Wim Leers’s picture

Thanks for the commit, especially thanks for the sample issue, now I know what the recommended way to do this is :)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Minor edits