Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
On the site maintenance admin screen, after setting the status of an offline site back to "online" and saving the change, the page still displays the "operating in off-line mode" message at the top. It does not display afterwards when moving to display other pages and really is only the display of a wrong status message on the site maintenance admin screen immediately after having validated the change.
Not a big deal, but it has been like that for a few releases now, and I thought I would report this little annoyance at last ;-)
Comment | File | Size | Author |
---|---|---|---|
#19 | site-maintenance-19.patch | 1.08 KB | RobLoach |
#17 | site-maintenance.patch | 977 bytes | RobLoach |
#12 | site_maintenance_message_3.patch | 874 bytes | RobLoach |
#5 | site_maintenance_message_2.patch | 756 bytes | RobLoach |
#2 | site_maintenance_message.png | 16.27 KB | BrightLoudNoise@drupal.org |
Comments
Comment #1
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedCurrently looking into this, the code that triggers this message is actually in menu.inc.
Comment #2
BrightLoudNoise@drupal.org CreditAttribution: BrightLoudNoise@drupal.org commentedAttached is a patch against system.admin.inc that sets a message of "Operating in on-line mode." while system_offline == 0 for the site maintenance form.
I'm wondering if the offline message should be cleared first, as having conflicting messages displayed may be confusing. *Screenshot attached.
Comment #3
catchclearing the off-line message would make sense to me. Otherwise at least these are displayed in order, so an admin could work out it was a status change (rather than simply wrong).
Comment #4
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedThey way these messages are triggered don't make it very easy to just clear the "off-line" message using get_messages($clear_queue), it also clobbers the "config options have been saved" message as they are both status type messages.
The current patch is an improvement in any case, so if someone could review and approve, that would be great.
Comment #5
RobLoachI suggest we hide the message from displaying when they visit admin/settings/site-maintenance. They are already on the site maintenance page, so they already know that it's in offline mode. Why bother displaying the message? This should fix the workflow.
Comment #6
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedRob, that sounds reasonable to me. Do we need to re-roll these as a single patch to get this RTBC?
Comment #7
RobLoachNope, just review and test the patch I uploaded, and then set to RTBC if it works! ;-)
Comment #8
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedPostponed to D7 due to string freeze as of D6 RC1.
Comment #9
Gábor HojtsyNo string change in the latest patch.
Comment #10
RobLoachComment #11
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedPatch no longer applies due to changes in menu.inc
Comment #12
RobLoachComment #13
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedPatch applies cleanly and removes the potentially confusing status message from the site maintenance config page.
Comment #14
Dries CreditAttribution: Dries commentedWe want to document this in the code, IMO.
Another solution might be to set that status message at a a later point in time. It looks like it might be set to early in the process?
Comment #15
RobLoachHow's this?
"Ensure that the off-line message is displayed only once [allowing for page redirects]. Also be sure to not display it on the site maintenance page so that it doesn't display it twice."
Comment #16
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedI've taken a stab at cleaning it up a bit
"Ensure that the off-line message is displayed only once [allowing for page redirects], and specifically suppress its display on the site maintenance page."
Comment #17
RobLoachComment #18
RobLoachNeeds roll from root.
Comment #19
RobLoachComment #20
coltrane#19 patch applies and words correctly. Message is not shown on the site maintenance page.
Comment #21
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedGreat, lets get this in there.
Comment #22
Gábor HojtsyGreat, #19 looks right, so committed that one. Also RTBC for 7.x.
Comment #23
RobLoachI think we should come up with a better solution for Drupal 7. Dries mentioned that we might be sending out the message a bit early?
Comment #24
Gábor HojtsyRob Loach: first get the patch committed, so Drupal 6 and 7 are not disconnected. Then work from there.
Comment #25
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #26
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.