Update status is not sending notification emails for all of my sites. I think it's a bug since it's on so many different boxes. All are Drupal 5.3, but I can confirm it didn't work on Druupal 5.2 either. All other outbound mail is working, ie. webform is sending emails just fine. All are running on linux with php 4.4.4 or better. All of these sites were configured to send to only one email address -- could this be the problem? I tried with different email addresses and it still didn't work. Since other modules that email are working, I'm assuming this is a bug? Sorry if I missed something.

CommentFileSizeAuthor
#5 patch_174.txt988 byteswebernet
#4 patch_173.txt795 byteswebernet

Comments

dww’s picture

dww
we/he/they
commented
Category: bug » support
Status: Active » Postponed (maintainer needs more info)

The email stuff is all cron-driven. Are you sure cron is correctly configured on all your sites? Furthermore, not all of your sites are necessarily in sync with each other in terms of *when* in a given 24 hour period each site is checking for updates. If you wanted to syncronize, you'd need to make sure that cron.php was getting invoked at the same time for all sites, and that your 'update_status_last' variable has the same value on all sites (so they'll all agree when 24 hours passed and they should check again).

chrisschaub’s picture

chrisschaub commented

Yep, cron is working just fine on all sites. I've verified this via the status report and watchdog. I've got it set to check daily which is also working. So, i'm assuming I should get an email at least once if not every day until I upgrade the out of date modules? Other mods that send mail are working just fine. Thanks for any help.

chrisschaub’s picture

chrisschaub commented

bump, still not working. any thoughts are greatly appreciated.

webernet’s picture

webernet commented
Category: support » bug
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new patch_173.txt795 bytes

I found the problem.

webernet’s picture

webernet commented
StatusFileSize
new patch_174.txt988 bytes

Actually, this might be better.

chrisschaub’s picture

chrisschaub commented

Is this going to make it into the dev cycle for this module? Just curious if this fix works for everyone.

dww’s picture

dww
we/he/they
commented

If people test it and report back here, and it works, then yes, it'll be committed.

dww’s picture

dww
we/he/they
commented
Version: 5.x-2.0 » 5.x-2.x-dev
Status: Needs review » Fixed

Oh bah. ;) Visual inspection of the patch and the rest of the function it's effecting shows this is obviously broken and the patch is the right thing to do. I committed #5 (for better consistency with the same code in core and the rest of this module) to DRUPAL-5--2 and HEAD, so this will be available in the 5.x-2.1 release (whenever that happens) or 5.x-2.x-dev in about 10 hours from now. Thanks webernet!

p.s. @webernet: Please don't forget the "-p" argument to patch... it took me an extra minute to figure out what function this was when I was verifying that the bug isn't in core, too (which, thankfully, it's not).

chrisschaub’s picture

chrisschaub commented

Thanks dww and webernet for getting this in.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

mariuss’s picture

mariuss commented

Having the exact same issue, this is an important bug. Can you push out a new version to cover this?

Last release is from August.

dww’s picture

dww
we/he/they
commented

Funny you should mention it. ;) I had completely forgotten about this, and we failed to put it in the CHANGELOG, so it's been off my mind as I've focused on other things. However, moments ago, I finally committed a major patch, http://drupal.org/node/197186, which includes some critical missing functionality from the 5.x-2.0 version (after I managed to get that into core in time for the 6.0-rc2 release). So, I was planning to cut a 5.x-2.1 release any day now. If you're interested making that a reality, please test the 5.x-2.x-dev version (http://drupal.org/node/143593). Thanks.

mariuss’s picture

mariuss commented

Installed the latest dev version. How soon should I see notification messages coming in? Right after the next cron run?

Will get back with feedback in a couple of days.

mariuss’s picture

mariuss commented

Using the dev version with a bunch of sites for the last 3 days or so, all working fine.

Emails are sent out as expected.