API page: http://api.drupal.org/api/drupal/core%21modules%21search%21search.pages....

The function initialize the $redirect variable, but that variable is never used from the function, nor is the variable defined as global variable.

CommentFileSizeAuthor
#9 drupal-remove-variable-1848774-9.patch457 bytesavpaderno
#3 drupal-remove-variable-1848774-3.patch477 bytesishadakota

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I checked the code used from the function in other Drupal versions. $redirect was introduced in Drupal 7, but the code has never used that variable, except when initializing it.

marcingy’s picture

marcingy commented
Issue tags: +Novice

Tagging as novice

ishadakota’s picture

ishadakota commented
Status: Active » Needs review
StatusFileSize
new drupal-remove-variable-1848774-3.patch477 bytes

Looks like this should have been removed in #497206: Avoid search conflicts with other forms, use menu API instead of search_get_keys().

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, drupal-remove-variable-1848774-3.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

#3: drupal-remove-variable-1848774-3.patch queued for re-testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Novice

#3: drupal-remove-variable-1848774-3.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushued to 8.x, thanks!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Needs review
StatusFileSize
new drupal-remove-variable-1848774-9.patch457 bytes

This is the patch for Drupal 7. The same variable that appears in the Drupal 8 code appears in Drupal 7's search_view().

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

How do you always find that stuff? ;) Looks good.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@Bedir I am the founder of the "Give home to an orphan variable" association. ;-)

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/d5be55f

Automatically closed -- issue fixed for 2 weeks with no activity.