Unsupported operand types in manualcrop.admin.inc when editing commerce_price field [#1847960]

After upgrading to Manual Crop 7.x-1.4 I'm getting a fatal error when I try to edit the commerce_price field on one of my products:

Fatal error: Unsupported operand types in /path/to/manual-crop/manualcrop.admin.inc on line 386

It looks like the manualcrop_supported_widgets($widget_type) check is failing. The assignment of $widget_type on line 377 doesn't match the structure I'm seeing in a var dump of the form element.

// Get the instance and widget type.
  $element = &$form['instance'];
  $widget_type = $element['widget']['type']['#value'];

Looks like it should be

// Get the instance and widget type.
  $element = $form['#instance'];
  $widget_type = $element['widget']['type'];

Drupal 7.17
Manual Crop 7.x-1.4
Commerce 7.x-1.4

Patch to follow.

Comment	File	Size	Author
#10	manual-crop-commerce-compatibility-1847960-10.patch	611 bytes	matthijs
#1	manualcrop-unsupported_operand-1847960-1.patch	616 bytes	garrettc

Comments

Comment #1

garrettc commented 22 November 2012 at 15:18

Status:

Active

» Needs review

Status	File	Size
new	manualcrop-unsupported_operand-1847960-1.patch	616 bytes

Comment #2

garrettc commented 22 November 2012 at 15:57

Status:

Needs review

» Needs work

Hmm, this might not work. Some forms have #instance and some have just instance. I'm not quite sure what the difference between them is supposed to be.

Comment #3

matthijs

Dutch

commented 22 November 2012 at 20:13

Assigned:	Unassigned	» matthijs
Status:	Needs work	» Fixed

Thanks for your patch, I ended up using:

$element = &$form[(isset($form['instance']) ? 'instance' : '#instance')];
$widget_type = $element['widget']['type'];

if (is_array($widget_type)) {
    $widget_type = $widget_type['#value'];
}

With this code both cases are covered ;-)

Comment #4

garrettc commented 24 November 2012 at 12:59

Status:

Fixed

» Needs work

I'm still getting the error, but now with a different line number, on the latest dev (7.x-1.4+12-dev, 23rd November):

Fatal error: Unsupported operand types in /Users/garrettc/Work/sandbox/wdcs/sites/all/modules/Media/manual-crop/manualcrop.admin.inc on line 391

It still seems that the manualcrop_supported_widgets($widget_type) check is failing. Manual crop shouldn't need to add anything to a commerce_price field.