7.x-2.0-rc4+4-dev - commerce_kickstart_user.module

line 124 is overwritten by line 125, div from prefix is never closed.

Sorry haven't quite got around to learning to make patches yet!

Comments

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Active » Needs review

actually it seems the divs seems closed. the overwriting line closes 2 divs.
but yes, it's confusing and it shouldn't be. thank you Sir.

here is a gerrit commit, that clean this up : https://code.drupalcommerce.org/#/c/548/
the same as it's for the user password form

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Status: Needs review » Needs work

Please read comments in gerrit.

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Priority: Major » Normal

It's not a major priority + the div is closed in the form suffix. the commit just clean up this a bit.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Needs work » Needs review

rebased/fixed the commit https://code.drupalcommerce.org/#/c/548/

rar’s picture

rar CreditAttribution: rar commented

There were a lot of div issues like this that were fixed over the last few weeks. Is there an RC5 planned for release soon?

bojanz’s picture

bojanz CreditAttribution: bojanz commented

We'll tag a new release at the end of next week.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.