Unnecessary ";" in system_update_181() [#184668]

In system.install for system_update_181() there is an extra ";" that I don't believe is necessary:

$ret[] = update_sql("ALTER TABLE {profile_fields} ADD autocomplete TINYint NOT NULL AFTER visibility ;");

I suggest removing the second to last ";".

The reason why I'm submitting so many of these is because I'm going through the entire 5.2 (will update to 5.3 soon) and making it compatible with SQL Server 2000. Thus, I'm coming across a lot of these things and figured I should share my thoughts. I will submit an overall core patch for SQL Server compatibility soon.

Comment	File	Size	Author
#4	system_install_1.patch	648 bytes	hazexp
#3	system_install_0.patch	648 bytes	hazexp

Comments

Comment #1

JirkaRybka commented 18 October 2007 at 19:42

Patches are (as far as I know) only worth submitting for the -dev versions, and additionally 5.x only accepts bugfixes now.

Otherwise I confirm, that this extra semicolon exists also in 6.x-dev (no wonder, inside an old update), and I consider this a syntax-consistency minor bug (but not changing status, since pcorbett announced a 5.x patch coming).