Closed (fixed)
Project:
Field Permissions
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
20 Nov 2012 at 14:18 UTC
Updated:
10 Mar 2017 at 17:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
kbasarab commentedThis would be a great addition I agree. Issue I see though is that field_permissions module doesn't implement anything with features. The features compatibility comes with the way permissions are added from the field forms. There might be a hook to implement this though in some other way though.
Comment #2
adamtong commentedI would like it to be exportable with Features. It will be great!
Thank you!
Comment #3
Angry Dan commentedThis is simple enough. I've written a patch which should provide the functionality. Just export a field base to have all of the field permission permissions exported along with it when applicable.
Comment #4
michielnugter commentedThanks for the patch. I tested the provided patch but it had a small issue. It looped through the wrong field_base array, exporting all the used field_base components instead of only the field_base components that will be exported in the feature. I created a new patch with these changes (sorry, svn patch). I hope anyone can review it and include it in the next module release.
Comment #6
japicoder commentedI did a re-roll of the svn patch and used git to generate a new one that can be tested, but I can't upload it. There's a way to upload this patch?
Comment #7
Angry Dan commentedYeah, just click "update this issue" and attach it at the bottom.
Comment #8
kerasai commented4: field_permissions.miscellaneous.1845798-4.patch queued for re-testing.
Comment #10
chriscohen commentedI have tried this patch (#4) and it seems to work fine, functionally. Not sure why it's failed testing though. This is a very old issue. Can we get some progress on this please? It's frustrating that this module doesn't allow its config to be exported to features!
Comment #11
Angry Dan commentedThe testing failed because the patch failed to apply. I'm having the same problem so here's a re-roll of #4
Comment #12
Angry Dan commentedComment #13
fullerja commentedPatch in #11 worked for me
Comment #14
arpitr commented3: field_permissions.miscellaneous.1845798-3.patch queued for re-testing.
Comment #16
k_zoltan commentedJust tested patch #1 and all works well.
Comment #17
k_zoltan commentedWould be great if we could get this commited since it doesn't break the current structure just adds an extra function for the "feature" feature.
Comment #18
paulsheldrake commentedThe patch in #11 worked for me
Comment #19
blainelang commented+1 for patch #11, thanks!!
With nearly 24,000 reported installs maybe it's time to promote this module as well out of beta.
Comment #20
paul.linney commentedPatch in #11 works great. +1 for rtbc.
Comment #22
kerasai commentedThis issue is already RTBC and should be included in the next release, whenever that might be. For the meantime, this patch is fine to apply to your sites.
Re-ran the automated test suite all good.
Manually test via Simplytest.me also works, field with "custom permissions" set up has those permissions included via dependency when added to a Feature module.
Comment #23
mile23Just a +1 in general for better features integration. It's currently giving me a headache. :-)
Patch applies. Here's a mini-review:
Don't load the include until after you check if it's needed.
Comment #24
esolitosUsing patch from #11 successfully. Thanks!
@mainteiners Can we have this committed?
Comment #25
alisonHi field_permissions maintainers! Do you know if you'll be committing this patch or not? I'm weighing pros/cons of applying to my sites. Thanks!
Comment #26
subhojit777+1 RTBC
Comment #28
mariacha1 commentedThanks for this work everyone! Getting #11 committed with Mile23's suggestion.
@jhedstrom I'm guessing this isn't relevant for the D8 branch?
Comment #30
hazong commentedIs this patch already applied?
Comment #31
kerasai commentedYes. This included in
7.x-1.0and up.It's also in any version of the
7.x-1.x-devrelease after7.x-1.0-beta2release.