Convert views/templates/views-view-rss.tpl.php to twig

Tagging.

Converted to core patch. Removes views-view-rss.tpl.php, adds views-view-rss.html.twig

Reassigning to Drupal core.

#3: drupal-twig-views-view-rss-1843760.patch queued for re-testing.

+++ /dev/nullundefined
@@ -1,20 +0,0 @@
-<?php print "<?xml"; ?> version="1.0" encoding="utf-8" <?php print "?>"; ?>

+++ b/core/modules/views/templates/views-view-rss.html.twigundefined
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8" ?>

Just this line shows how much better twig is :)

+++ b/core/modules/views/templates/views-view-rss.html.twigundefined
@@ -0,0 +1,28 @@
+ * - link: link to the feed (the view path)
+ * - namespaces: XML namespaces (added automatically)
+ * - title: title (as set in the view)
+ * - description: feed description (from feed settings)
+ * - langcode: language encoding
+ * - channel_elements: the formatted channel elements

I'm wondering whether you know what the codestyle tells us about these descriptive lines. Should they be full sentences?

This looks really great in general.

@dawehner I confess I don't really know. There were no comments in the original patch or file, so I write these in as best I could. I don't know if there is a format I was supposed to follow, though if there is point me in the right direction and I'll reroll it!

The general guidelines are that all documentation should form complete sentences (http://drupal.org/node/1354#drupal) and the template documentation standards show this in action (http://drupal.org/node/1354#templates). There's also the Twig-specific standards, I think for example the @ingroup views_templates needs to be @ingroup themeable.

So needs work, sorry.

Adding twig tag

grabbing

updating documentation.
used views-exposed-form.html.twig as a guide/sample and used both @ingroup statements.

This time I GOT IT.

Nice work, if you want you can uppercase the first letter on those sentences as well.

Also we can clean up the docs and variables on the preprocess function

/**
 * Preprocess an RSS feed
 */
function template_preprocess_views_view_rss(&$vars) {

replacing $vars with $variables

  $view     = &$vars['view'];
  $options  = &$vars['options'];
  $items    = &$vars['rows'];

  $style    = &$view->style_plugin

And removing the spaces infront of these variables.

Tagging.

#19 - We don't have to convert the $vars to $variables just yet, that's a task for another day #1963942: Change all instances of $vars to $variables.

This is a very minor point but could we add @see template_preprocess() to the template comments?

Other than that though I think the code style in this patch is good. Essentially, once the documentation is updated it's ready for manual testing and for manual testing steps to be written :)

Tagging as novice to add @see template_preprocess() to the .html.twig between the variables and the @ingroup, see Twig coding standards for an example.

+++ b/core/modules/views/templates/views-view-rss.html.twigundefined
@@ -0,0 +1,29 @@
+ * - link: link to the feed (the view path).
+ * - namespaces: XML namespaces (added automatically).
+ * - title: title (as set in the view).
+ * - description: feed description (from feed settings).
+ * - langcode: language encoding.
+ * - channel_elements: the formatted channel elements.
+ * - items: the feed items themselves.

Also, these descriptions should be complete sentences (starting in a capital letter) per http://drupal.org/node/1354#drupal.

Oops, tag.

If you'd like to work on this, please assign the issue to yourself. If you get stuck, drop by #drupal-twig on IRC or post your questions here. Thanks!

I didn't notice this was already assigned.

@webthingee - same as #1843740: Convert views/templates/views-exposed-form.tpl.php to twig, you're more than welcome to see this through but if you can't for whatever reason please unassign.

#21 held off on any variables.
#22 added @see template_preprocess()
#22 updated docs to complete sentences.

Ended up with a fresh patch after updating latest 8.x repo.

setting this patch to needs review.

looking at code standards again, seeing I need an extra space.
re-rolled....

Okay, testing manually. Markup looks good! Doc block looks great. :)

before:

<?xml version="1.0" encoding="utf-8" ?><rss version="2.0" xml:base="http://d8core.dev/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:foaf="http://xmlns.com/foaf/0.1/" xmlns:og="http://ogp.me/ns#" xmlns:rdfs="http://www.w3.org/2000/01/rdf-schema#" xmlns:sioc="http://rdfs.org/sioc/ns#" xmlns:sioct="http://rdfs.org/sioc/types#" xmlns:skos="http://www.w3.org/2004/02/skos/core#" xmlns:xsd="http://www.w3.org/2001/XMLSchema#">
  <channel>
    <title>Drupal 8</title>
    <link>http://d8core.dev/</link>
    <description></description>
    <language>en</language>
    ...
  </channel>
</rss>

after:

  <?xml version="1.0" encoding="utf-8" ?>
  <rss version="2.0" xml:base="http://d8core.dev/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:foaf="http://xmlns.com/foaf/0.1/" xmlns:og="http://ogp.me/ns#" xmlns:rdfs="http://www.w3.org/2000/01/rdf-schema#" xmlns:sioc="http://rdfs.org/sioc/ns#" xmlns:sioct="http://rdfs.org/sioc/types#" xmlns:skos="http://www.w3.org/2004/02/skos/core#" xmlns:xsd="http://www.w3.org/2001/XMLSchema#">
    <channel>
      <title>Drupal 8</title>
      <link>http://d8core.dev/</link>
      <description></description>
      <language>en</language>
      ...
    </channel>
  </rss>

Since #25 passed tests and #27 just adds another space, I'm confident marking this RTBC :)

This looks perfect!

Tagging for profiling.

Doc updates, missing preprocess docs. Removed $options because they weren't being used and =& references.

I'll profile this one.

Profiling results:

Added this code to template_preprocess_views_view_rss() to isolate the profiling to only this template conversion (not comparing loading Twig itself):

  $node = node_load(101);
  $vars['description'] .= theme('node', node_view($node));

=== views-view-rss-8.x..views-view-rss-8.x compared (519aa9d3a1b8c..519aaa3d27345):

ct  : 41,342|41,342|0|0.0%
wt  : 267,443|267,501|58|0.0%
cpu : 251,455|250,983|-472|-0.2%
mu  : 18,107,976|18,107,976|0|0.0%
pmu : 18,186,400|18,186,400|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519aa9d3a1b8c&...

=== views-view-rss-8.x..views-view-rss-1843760-32 compared (519aa9d3a1b8c..519aaa62743ee):

ct  : 41,342|41,424|82|0.2%
wt  : 267,443|267,876|433|0.2%
cpu : 251,455|251,969|514|0.2%
mu  : 18,107,976|18,140,752|32,776|0.2%
pmu : 18,186,400|18,212,776|26,376|0.1%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519aa9d3a1b8c&...

Updated issue summary.

+1. Ready for #1987510: [meta] Convert all core *.tpl.php templates to Twig as singular patch

+++ b/core/modules/views/templates/views-view-rss.html.twigundefined
@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="utf-8" ?>

+++ /dev/nullundefined
@@ -1,20 +0,0 @@
-<?php print "<?xml"; ?> version="1.0" encoding="utf-8" <?php print "?>"; ?>

Yay!

Committed a312df8 and pushed to 8.x. Thanks!