Some patches have been rolled against the Drupal 8 Twig sandbox, and some Views patches have been committed to the sandbox. In our effort to get these patches/commits out of the sandbox and into core, follow each of the linked issues to find the status of work in the sandbox including preprocess funtions in views module files and/or .html.twig files in core/themes/stark/templates/views/.
.html.twig files need to be in core/modules/views/templates, with any existing templates moved out of core/themes/stark/templates/views.
Remaining
Template file conversions
- #1843740: Convert views/templates/views-exposed-form.tpl.php to twig
- #1843742: Convert views/templates/views-more.tpl.php to twig
- #1843744: Convert views/templates/views-view.tpl.php to twig
- #1843746: Convert views/templates/views-view-field.tpl.php to Twig
- #1843748: Convert views/templates/views-view-fields.tpl.php to twig Assigned to: tlattimore
- #1843750: Convert views/templates/views-view-grid.tpl.php to twig
- #1843752: Convert views/templates/views-view-grouping.tpl.php to twig
- Discovered during testing: #1997866: Erroneous Views grouping and grouping_level template variables
- #1843754: Convert views/templates/views-view-list.tpl.php to twig
- #1843758: Convert views/templates/views-view-row-rss.tpl.php to twig
- #1843760: Convert views/templates/views-view-rss.tpl.php to twig
- #1843762: Convert views/templates/views-view-summary.tpl.php to twig
- #1843764: Convert views/templates/views-view-summary-unformatted.tpl.php to twig Assigned to: tlattimore
- #1843766: Convert views/templates/views-view-table.tpl.php to twig
- #1843770: Convert views/templates/views-view-unformatted.tpl.php to twig
Theme function conversions
- #1912604: Convert theme_views_mini_pager to twig
- #1912600: Remove theme_views_form_views_form in favour of a prerender callback.
- #1912606: Remove theme_views_view_grouping function
- #1963764: Convert theme_views_view_mapping_test() to Twig Assigned to: pwieck
- theme_views_view_field() will be removed in #1843746: Convert views/templates/views-view-field.tpl.php to Twig
Related Issues
#1898472: [meta] Convert views_ui module to Twig
#1757550: [Meta] Convert core theme functions to Twig templates
Comment | File | Size | Author |
---|---|---|---|
#1 | views-to-twig-rough.patch | 17.64 KB | joelpittet |
Comments
Comment #1
joelpittetThis is rough patch of all the views (not views_ui because didn't know the path they should go to)
Some of this may be better than others, but may give someone a headstart.
Comment #2
joelpittetAll patches were moved to their respective non-meta issues.
Comment #3
dawehnerPlease tag everything related with views with VDC, so people can find it.
Comment #4
mbrett5062 CreditAttribution: mbrett5062 commentedHave now tagged all the separate issues with VDC as per #3.
Comment #4.0
mbrett5062 CreditAttribution: mbrett5062 commentedAdded all the views tpl conversion issues.
Comment #5
FluxSauce CreditAttribution: FluxSauce commentedI've started committing these as part of #1898470: [meta] Convert views module to Twig at SANDcamp 2013. My apologies now for some of the messy commits - joelpittet has done a fantastic job, among many others.
Comment #6
c4rl CreditAttribution: c4rl commentedCan you explain why you are committing issues that were marked "needs review" and not yet marked "reviewed & tested by the community?"
Comment #7
steveoliver CreditAttribution: steveoliver commentedI had him commit directly and we should have stuck to posting patches.
Comment #8
damiankloip CreditAttribution: damiankloip commentedAre we going to get a proper issue for these? We don't get too much exposure to these and I definitely want to review them before they get committed, rather than being committed in one super patch.
Comment #9
c4rl CreditAttribution: c4rl commented@damiankloip #8 As discussed just now in IRC, we'll plan to move the linked issues above to the core queue so that we don't submit a super patch.
Comment #10
c4rl CreditAttribution: c4rl commentedTagging
Comment #10.0
c4rl CreditAttribution: c4rl commentedLinked to D8 meta
Comment #10.1
gollyg CreditAttribution: gollyg commentedAdd links to theme function issues
Comment #11
steveoliver CreditAttribution: steveoliver commentedMoving this to the core queue, marking #1898470: [meta] Convert views module to Twig as duplicate.
Comment #12
steveoliver CreditAttribution: steveoliver commentedComment #12.0
steveoliver CreditAttribution: steveoliver commentedUpdated issue summary.
Comment #12.1
steveoliver CreditAttribution: steveoliver commentedUpdated issue summary with notes about status and conversion effort.
Comment #12.2
steveoliver CreditAttribution: steveoliver commentedUpdated issue summary.
Comment #12.3
steveoliver CreditAttribution: steveoliver commentedAdded #1918648: Convert theme_views_ui_style_plugin_table to Twig.
Comment #12.4
joelpittetremoving views-view-row-comment conversion
Comment #12.5
star-szrAdding last theme function conversion issue
Comment #12.6
star-szrRemove views_ui issues
Comment #12.7
star-szrNote about theme_views_view_field()
Comment #12.8
star-szrRemove unneeded period
Comment #12.9
star-szrAdd views-view--frontpage.tpl.php
Comment #12.10
star-szrUpdate to de-duplicate theme_views_view_grouping()/views-view-grouping.tpl.php
Comment #12.11
star-szrFix issue # for views-view-grouping
Comment #12.12
joelpittetmoving theme function
Comment #12.13
star-szrSort out view-view-grouping - add reference to template file in templates section, remove duplicate from theme function section
Comment #13
star-szrAs discussed with @dawehner we will remove
@ingroup views_templates
from all Views and Views UI .html.twig templates. If you are working on patches on any of the sub-issues that have this line in the template(s) it would be a huge help if you can reroll to remove that line. Thanks!Comment #13.0
star-szrOops, we're converting not removing views-view-grouping :)
Comment #13.1
star-szrAdd assignment dealie (@ signs)
Comment #14
steveoliver CreditAttribution: steveoliver commentedLet's create a follow-up issue for any issues we have with Views and Views UI docblocks. All these templates have been commited. Closing this issue. :)
Comment #15
star-szrStill theme functions to convert here, re-opening.
Comment #15.0
star-szrAdded reference to #1997866 as a sub-item of #1843752, per request by thedavidmeister on comment #33 of that issue.
Comment #16
joelpittetClosing this as all have been complete, nice work everybody!