Some patches have been rolled against the Drupal 8 Twig sandbox, and some Views patches have been committed to the sandbox. In our effort to get these patches/commits out of the sandbox and into core, follow each of the linked issues to find the status of work in the sandbox including preprocess funtions in views module files and/or .html.twig files in core/themes/stark/templates/views/.

.html.twig files need to be in core/modules/views/templates, with any existing templates moved out of core/themes/stark/templates/views.

Remaining

Template file conversions

Theme function conversions

#1898472: [meta] Convert views_ui module to Twig
#1757550: [Meta] Convert core theme functions to Twig templates

CommentFileSizeAuthor
#1 views-to-twig-rough.patch17.64 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet’s picture

Status: Active » Needs work
FileSize
17.64 KB

This is rough patch of all the views (not views_ui because didn't know the path they should go to)

Some of this may be better than others, but may give someone a headstart.

joelpittet’s picture

All patches were moved to their respective non-meta issues.

dawehner’s picture

Issue tags: +VDC

Please tag everything related with views with VDC, so people can find it.

mbrett5062’s picture

Have now tagged all the separate issues with VDC as per #3.

mbrett5062’s picture

Project: » Drupal core
Issue summary: View changes

Added all the views tpl conversion issues.

FluxSauce’s picture

Project: Drupal core »

I've started committing these as part of #1898470: [meta] Convert views module to Twig at SANDcamp 2013. My apologies now for some of the messy commits - joelpittet has done a fantastic job, among many others.

c4rl’s picture

My apologies now for some of the messy commits

Can you explain why you are committing issues that were marked "needs review" and not yet marked "reviewed & tested by the community?"

steveoliver’s picture

I had him commit directly and we should have stuck to posting patches.

damiankloip’s picture

Are we going to get a proper issue for these? We don't get too much exposure to these and I definitely want to review them before they get committed, rather than being committed in one super patch.

c4rl’s picture

Are we going to get a proper issue for these?

@damiankloip #8 As discussed just now in IRC, we'll plan to move the linked issues above to the core queue so that we don't submit a super patch.

c4rl’s picture

Issue tags: +Twig

Tagging

c4rl’s picture

Project: » Drupal core
Issue summary: View changes

Linked to D8 meta

gollyg’s picture

Issue summary: View changes

Add links to theme function issues

steveoliver’s picture

Title: [META] Views conversion to Twig » [META] Convert views module to Twig
Version: » 8.x-dev
Component: Twig templates conversion (front-end branch) » views.module
Status: Needs work » Active

Moving this to the core queue, marking #1898470: [meta] Convert views module to Twig as duplicate.

steveoliver’s picture

Title: [META] Convert views module to Twig » [meta] Convert views module to Twig
steveoliver’s picture

Issue summary: View changes

Updated issue summary.

steveoliver’s picture

Issue summary: View changes

Updated issue summary with notes about status and conversion effort.

steveoliver’s picture

Issue summary: View changes

Updated issue summary.

steveoliver’s picture

Issue summary: View changes

Added #1918648: Convert theme_views_ui_style_plugin_table to Twig.

joelpittet’s picture

Issue summary: View changes

removing views-view-row-comment conversion

star-szr’s picture

Issue summary: View changes

Adding last theme function conversion issue

star-szr’s picture

Issue summary: View changes

Remove views_ui issues

star-szr’s picture

Issue summary: View changes

Note about theme_views_view_field()

star-szr’s picture

Issue summary: View changes

Remove unneeded period

star-szr’s picture

Issue summary: View changes

Add views-view--frontpage.tpl.php

star-szr’s picture

Issue summary: View changes

Update to de-duplicate theme_views_view_grouping()/views-view-grouping.tpl.php

star-szr’s picture

Issue summary: View changes

Fix issue # for views-view-grouping

joelpittet’s picture

Issue summary: View changes

moving theme function

star-szr’s picture

Issue summary: View changes

Sort out view-view-grouping - add reference to template file in templates section, remove duplicate from theme function section

star-szr’s picture

As discussed with @dawehner we will remove @ingroup views_templates from all Views and Views UI .html.twig templates. If you are working on patches on any of the sub-issues that have this line in the template(s) it would be a huge help if you can reroll to remove that line. Thanks!

star-szr’s picture

Issue summary: View changes

Oops, we're converting not removing views-view-grouping :)

star-szr’s picture

Issue summary: View changes

Add assignment dealie (@ signs)

steveoliver’s picture

Status: Active » Fixed

Let's create a follow-up issue for any issues we have with Views and Views UI docblocks. All these templates have been commited. Closing this issue. :)

star-szr’s picture

Status: Fixed » Active

Still theme functions to convert here, re-opening.

star-szr’s picture

Issue summary: View changes

Added reference to #1997866 as a sub-item of #1843752, per request by thedavidmeister on comment #33 of that issue.

joelpittet’s picture

Issue summary: View changes
Status: Active » Fixed

Closing this as all have been complete, nice work everybody!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.