Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Nov 2012 at 01:58 UTC
Updated:
29 Jul 2014 at 21:32 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
joelpittetThis is rough patch of all the views (not views_ui because didn't know the path they should go to)
Some of this may be better than others, but may give someone a headstart.
Comment #2
joelpittetAll patches were moved to their respective non-meta issues.
Comment #3
dawehnerPlease tag everything related with views with VDC, so people can find it.
Comment #4
mbrett5062 commentedHave now tagged all the separate issues with VDC as per #3.
Comment #4.0
mbrett5062 commentedAdded all the views tpl conversion issues.
Comment #5
fluxsauce commentedI've started committing these as part of #1898470: [meta] Convert views module to Twig at SANDcamp 2013. My apologies now for some of the messy commits - joelpittet has done a fantastic job, among many others.
Comment #6
c4rl commentedCan you explain why you are committing issues that were marked "needs review" and not yet marked "reviewed & tested by the community?"
Comment #7
steveoliver commentedI had him commit directly and we should have stuck to posting patches.
Comment #8
damiankloip commentedAre we going to get a proper issue for these? We don't get too much exposure to these and I definitely want to review them before they get committed, rather than being committed in one super patch.
Comment #9
c4rl commented@damiankloip #8 As discussed just now in IRC, we'll plan to move the linked issues above to the core queue so that we don't submit a super patch.
Comment #10
c4rl commentedTagging
Comment #10.0
c4rl commentedLinked to D8 meta
Comment #10.1
gollyg commentedAdd links to theme function issues
Comment #11
steveoliver commentedMoving this to the core queue, marking #1898470: [meta] Convert views module to Twig as duplicate.
Comment #12
steveoliver commentedComment #12.0
steveoliver commentedUpdated issue summary.
Comment #12.1
steveoliver commentedUpdated issue summary with notes about status and conversion effort.
Comment #12.2
steveoliver commentedUpdated issue summary.
Comment #12.3
steveoliver commentedAdded #1918648: Convert theme_views_ui_style_plugin_table to Twig.
Comment #12.4
joelpittetremoving views-view-row-comment conversion
Comment #12.5
star-szrAdding last theme function conversion issue
Comment #12.6
star-szrRemove views_ui issues
Comment #12.7
star-szrNote about theme_views_view_field()
Comment #12.8
star-szrRemove unneeded period
Comment #12.9
star-szrAdd views-view--frontpage.tpl.php
Comment #12.10
star-szrUpdate to de-duplicate theme_views_view_grouping()/views-view-grouping.tpl.php
Comment #12.11
star-szrFix issue # for views-view-grouping
Comment #12.12
joelpittetmoving theme function
Comment #12.13
star-szrSort out view-view-grouping - add reference to template file in templates section, remove duplicate from theme function section
Comment #13
star-szrAs discussed with @dawehner we will remove
@ingroup views_templatesfrom all Views and Views UI .html.twig templates. If you are working on patches on any of the sub-issues that have this line in the template(s) it would be a huge help if you can reroll to remove that line. Thanks!Comment #13.0
star-szrOops, we're converting not removing views-view-grouping :)
Comment #13.1
star-szrAdd assignment dealie (@ signs)
Comment #14
steveoliver commentedLet's create a follow-up issue for any issues we have with Views and Views UI docblocks. All these templates have been commited. Closing this issue. :)
Comment #15
star-szrStill theme functions to convert here, re-opening.
Comment #15.0
star-szrAdded reference to #1997866 as a sub-item of #1843752, per request by thedavidmeister on comment #33 of that issue.
Comment #16
joelpittetClosing this as all have been complete, nice work everybody!