Clicking delete on the confirmation form just redirects me back to the confirmation form.

CommentFileSizeAuthor
#3 commons_groups-actions_button_submit_overriding_defaults-1842674-3.patch2.31 KBpierrepaul

Comments

pierrepaul’s picture

pierrepaul commented
Assigned: Unassigned » pierrepaul
ezra-g’s picture

ezra-g commented

This may be related to #1841418: Undefined property: stdClass::$updated in commons_wikis_node_update() (see comment 3).

pierrepaul’s picture

pierrepaul commented
Status: Active » Needs review
StatusFileSize
new commons_groups-actions_button_submit_overriding_defaults-1842674-3.patch2.31 KB

I'm not sure you're gonna like my patch, but I'm welcome to any changes to it.

Currently we were adding a #submit function on the action button. The delete form has #submit on the form itself, having a #submit in the button seems to override the $form['#submit'] when it's set.

I could also check if $form['action']['submit']['#submit'] is set, but I found this way more self-explanatory.

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Thanks, Pierre Paul.

I committed a more concise fix: http://drupalcode.org/project/commons_groups.git/blobdiff/fa3740e27e2331....

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.