This function does not need drupal_write_record() as the record is not used afterwards; changing that to db_merge() improves DX (callers do not need to check whether a record exists) and possibly also performance.

Patch coming.

CommentFileSizeAuthor
#1 fontyourface-Rewrite_fontyourface_add_tags_to_font_to_use_db_merge-1841604-1.patch968 bytesDrave Robber
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Drave Robber’s picture

Drave Robber CreditAttribution: Drave Robber commented
Status: Active » Needs review
FileSize
fontyourface-Rewrite_fontyourface_add_tags_to_font_to_use_db_merge-1841604-1.patch968 bytes

Here it is.

sreynen’s picture

sreynen CreditAttribution: sreynen commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.