Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#8 | field-test-1839082-8.patch | 14.1 KB | Berdir |
#8 | field-test-1839082-8-interdiff.txt | 1.04 KB | Berdir |
#5 | field-test-1839082-5.patch | 14.1 KB | Berdir |
#1 | field-test-1839082-1.patch | 3.59 KB | Berdir |
Comments
Comment #1
BerdirNo test coverage yet, not really sure how much use that actually is. I't just a copy & paste of other tests.
What might be interesting would be to test shape as that does not use ->value but shape and color.
Comment #3
Berdir#1: field-test-1839082-1.patch queued for re-testing.
Comment #4
fagoThis should reference the class now, for both field types. Else it looks good to me, so let's add basic test coverages and move on?
Comment #5
BerdirAdded test for both field types, including a base test class for all field type item tests with a faster setup (less full module installs) and converted existing tests to that base class.
Comment #6
fagoGreat work on the tests!
shape field?
again, field field.
ouch. Can we rename the function instead?
Comment #7
BerdirWill re-roll for the other two changes. I'd like to keep changes to the test_entity related code as minimal as possible. I am working on completely replacing it over in #1822000: Remove Drupal\field_test\Plugin\Entity\Type\TestEntity in favor of EntityTest. The function is references quite a bit from other files that I would have to change as well.
Comment #8
BerdirFixed the comments.
Comment #9
fagoThanks, new comments read good.
Sounds good!
Comment #10
webchickCommitted and pushed to 8.x. Thanks!