Because the image_scale_and_crop_effect function does not respect the upscale parameter, images are upscaled even when the 'upscale' checkbox is not selected. Patch forthcoming.

CommentFileSizeAuthor
#1 manual_crop-respect_upscale_setting-1835842-1.patch498 bytesacrollet

Comments

acrollet’s picture

acrollet commented
Status: Active » Needs review
StatusFileSize
new manual_crop-respect_upscale_setting-1835842-1.patch498 bytes
matthijs’s picture

matthijs
Primary language Dutch
commented
Assigned: Unassigned » matthijs
Status: Needs review » Fixed

Committed! Thanks for the patch!

Matthijs

acrollet’s picture

acrollet commented

excellent, thank *you* for the module and quick response!

matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Fixed » Active

Hi,

I just reverted this patch because it results in a faulty image in some cases. I'll put some time in a better solution (to fix your issue again) soon!

Matthijs

matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Active » Fixed

A new patch, that made the default/automated cropping a bit smarter, has been committed!

Matthijs

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.