Font Awesome is awesome, isn't it? for a long time before, i had to add the font-awesome library to every theme handly, by now i created this module, so every theme can share the library.

The module includes minimal theme functions, and it's easy to be overrided by theme.
It is currently supporting Drupal 6, but soon 7.

The project's page is here:
http://drupal.org/sandbox/ispboy/1834648
git clone http://git.drupal.org/sandbox/ispboy/1834648.git font_awesome

Files: 
CommentFileSizeAuthor
#10 newline.png9.01 KBispboy

Comments

ispboy’s picture

Status:Active» Needs review

needs review?

sreynen’s picture

FYI, there are 2 other projects working to get Font Awesome integrated into the existing @font-your-face module (which I maintain):

http://drupal.org/sandbox/nick_schuch/1480250
http://drupal.org/sandbox/progpapa/1529360

I've been working with both, trying to encourage more collaboration here, and would be happy to work with you as well if you're interested. That's a little more work, but I think it has a lot more potential.

vineet.osscube’s picture

Status:Needs work» Needs review

Status - Needs Work

Manual Review :

You need to fix the following in font_awesome.module file :

1. You need to pass link title or taxonomy title through check_plain() before it can be put inside HTML.
2.Always use a space between the dot and the concatenated parts to improve readability.
3.Arrays should be formatted with a space separating each element (after the comma), and spaces around the => key association operator line 72 in font_awesome.module file.

I suggest you to take a look at this page:
http://ventral.org/pareview/httpgitdrupalorgsandboxispboy1834648git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

sreynen’s picture

Status:Needs review» Needs work

#3 sounds like needs work.

ispboy’s picture

1. You need to pass link title or taxonomy title through check_plain() before it can be put inside HTML.

I prefer to let it be, some other modules may output a formatted title.
I won't modify the original, just add a icon before it.

ispboy’s picture

I've been working with both, trying to encourage more collaboration here, and would be happy to work with you as well if you're interested. That's a little more work, but I think it has a lot more potential.

Thanks. I would consider it when I finished the basic work.

ispboy’s picture

Default branch changed to 7.x. Coder module found no problem about it.

ispboy’s picture

well, added the check_plain() and spaces.

alex.sorokin.v’s picture

Hi!

Here is the report from manual review done of your code:
1. Please make sure each of your module file ends with a new line. Right now 'font_awesome.module' without new line in ends.
2. Add point at the end of each comment line. Please see line 20 - without stop point ('font_awesome.module').
3. Add new line after 'break' in 'case'-structure. http://drupal.org/coding-standards#controlstruct

Please also fix all issues from http://ventral.org/pareview/httpgitdrupalorgsandboxispboy1834648git

-regards

ispboy’s picture

Status:Needs review» Needs work
StatusFileSize
new9.01 KB

What is "single new line"?

Is this a single new line?

but it still told me that "Files must end in a single new line character".

FILE: ...review/sites/all/modules/pareview_temp/test_candidate/font_awesome.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
6 | ERROR | Files must end in a single new line character

alex.sorokin.v’s picture

Hi!

You need to add "\n" after last line in file.

-regards

alex.sorokin.v’s picture

Example file:
<?php
line 1 \n
line 2 \n
....
last line \n

ispboy’s picture

Thanks Alex. But the blue "$" means "\n", vi editor show it that way.

klausi’s picture

Status:Needs work» Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

Issue summary:View changes

add the git url

priyankprajapati’s picture

Issue summary:View changes