Great module. Thanks a lot! I just have a few unasked-for suggestions.
Currently, this module is configured on the permissions page with the following permission:
Show text format dropdown
Show the text format dropdowns where more than one text format is available. If a user does not have this permission then the text format dropdown will be displayed in a collapsed fieldset.
I find that to be very confusing. In essence, you have to remove a permission from a role in order to activate the module. That's backwards.
I also think it's strange to have the settings on the permissions page. Usually, permissions are about allowing or not allowing a user to do something. This is more of a setting. So here are my suggestions:
- Create a settings page for the hide_formats module under Configuration -> Content Authoring -> Hide Formats
- Remove the permissions entirely.
What do you think? I might be able to help code this, but, before I jump in, I'd like to know what you think.
Comments
Comment #1
carinadigital commentedThe reason the permission are created that way is so that we don't change the behaviour of the site when we install the module. It's deliberate.
We could move the permissions to it's own page, but drupal's permissions system is already role specific and requires very little coding to use. You would have to duplicate functionality of checking access and role based forms to achive this so I wouldn't recommend.
Comment #2
ldweeks commentedThanks for the response, which is fair enough.
My suggestion, then, is to change the permission text to say the following:
I think, in general, that permissions are off when you install modules, and you have to go and turn them on when you actually want to use them. I think this change would be much less confusing.
I'm grateful for the module, whatever you choose to do.
Comment #3
carinadigital commentedThanks for the input. Have you seen #1377744: Change hook_permission() from "hide text format dropdown" to "show text format dropdown" .
I think this whole area of terminology is quite confusing. I agree it could be better but I don't want to keep changing the names of permissions arbitrarily. If we can come up with an overall system then I am happy to change it. At the moment though I'd rather try to complete the hide entirely feature request which may then make me rethink the names and permissions available.
Comment #4
ldweeks commentedThat's entirely reasonable. I'll go ahead and close this out so that your issue queue isn't cluttered up. Thanks for listening!