Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Errors: 

matchmedia.js: line 78, col 24, Expected '!==' and instead saw '!='.

1 error
CommentFileSizeAuthor
core-js-jshint-matchmedia.patch516 bytesnod_

Comments

seutje’s picture

seutje commented
Status: Needs review » Reviewed & tested by the community

I thought this was a straight copy from Paul Irish' polyfill and was all "are we JSHinting 3rd party libraries now?", but I see this isn't entirely the original, so might as well...

didn't hit any other flags.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Let's put a pull request on github for the upstream change though?

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Reviewed & tested by the community

No need for upstream pull request. That part of the code is our custom code.

Patch looks good...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.