Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Current this works (with #1831524: Previous/Next revision does not show diffs), but the integration is bad, with the context jumping from the Diff modules page callbacks and the Workflow Moderation page callbacks.
Patch coming.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | diff-better-workbench-moderation-integration-1833950-9.patch | 2.43 KB | brockfanning |
Comments
Comment #1
Alan D. CreditAttribution: Alan D. commentedComment #2
hass CreditAttribution: hass commentedNot sure why your opened a new case, but this patch works for me. Here is an updated patch without tabs (code style).
Comment #3
Alan D. CreditAttribution: Alan D. commentedYou picked up a bug in the standard view / marked down view in the other thread. This was absolutely independent to Workbench Moderation, it was simply more obvious when using this module :)
This patch directly resolves the integration issues in relation to keeping context when navigating around using Workflow Moderation module.
Thanks for catching the tabs, I running four individual Eclipse workspaces that are still not 100% tab free.
Only moderate level of testing, so waiting on others to rtbtc this one.
Comment #4
hass CreditAttribution: hass commentedYou should not expect reviews... :-( commit it if it's good and working.
Comment #5
Alan D. CreditAttribution: Alan D. commentedlol. Then I'll take the approach of core. If 100% happy, push through prior to a release, else (as in this case - only 97% happy) push to dev after the release.
Comment #6
hass CreditAttribution: hass commentedWho are these 3%? I'm fine with it. Can do another review with and without :-)
PS: I never got one proper review in the google analytics queue for past 5 years. Just as one example with 250k installs... Just to get a feeling about reviews in contrib. I expect nothing anymore.
Comment #7
Alan D. CreditAttribution: Alan D. commentedRevisioning / diff menu items are breaking with this patch
Comment #8
rajmataj CreditAttribution: rajmataj commentedIs there any new work on this? I am currently running:
On a content type where Workbench has created a field of type: 'Workbench Access settings', changes made to a node and then viewed with the 'Preview Changes' button do not register any changes made to the workbench section. All other fields are showing a change if changed but Workbench seems to be the exception.
Comment #9
brockfanning CreditAttribution: brockfanning commentedI am not sure how exactly things were breaking as mentioned in #7, but here is a reroll of Hass' patch (which works great by the way). I left out one section related to Diff 2.x support, because I wasn't sure if that is still needed.
Comment #10
Alan D. CreditAttribution: Alan D. commentedWhen using the Revisioning module (not workbench), the menus broke. It was fairly apparent at the time, albeit 5 years ago, so fuzzy on the details.
Patch was fine against Workbench moderation at the time and it was only the cross-module testing that blocked this patch (aka was safe & working 5 years ago with just Workbench moderation)
Comment #11
jollysolutionsComment #12
Alan D. CreditAttribution: Alan D. commented@jollysolutions
Did you try this with the various node revisioning modules other than Workbench? This is rtbtc already in relation to Workbench, but it completely broke revisioning.
Being a generic utility module, it needs to support all.