We include nine variations of the 'Powered by Drupal' logo in our default misc/ directory. None of them are ever used, anywhere, ever.
Ever.
The tiny attached patch adds a title-less block containing one of these 'Powered by Drupal' badges, with a link to drupal.org, and enables it by default in the footer region of a fresh Drupal install. It can be disabled easily. It can be themed. It's less than fifty lines of code, including hook_help and the ability to choose the badge size and color.
Review this patch, because drupal.org needs even more google juice to absorb the world in a destructive singularity. If no one reviews it, I threaten to add actions support.
I have autocomplete, and I'm not afraid to use it.
Comment | File | Size | Author |
---|---|---|---|
#14 | powered_by_drupal_3_0.patch | 3.74 KB | greggles |
#10 | powered_by_drupal_2_0.patch | 3.9 KB | catch |
#3 | powered_by_drupal_2.patch | 3.73 KB | JirkaRybka |
#1 | powered-by-screenshot.png | 71.35 KB | eaton |
powered_by_drupal.patch | 3.73 KB | eaton | |
Comments
Comment #1
eaton CreditAttribution: eaton commentedAnd! For the skeptical! An attractive screenshot. Now, how much would you pay for this block? $59.95? $79.95? More? It's FREE!
I drank too much coffee.
Comment #2
JirkaRybka CreditAttribution: JirkaRybka commentedI would almost call this minor, but it may not hurt to have it. :)
Looking at the patch, though, I would rather write:
While there is absolutely no requirement that sites feature this link, it may BE used to show support for Drupal.
Comment #3
JirkaRybka CreditAttribution: JirkaRybka commentedEdit done (just that single 'be' word added).
Tested on fresh 6.x-dev: Works fine.
I'm not setting RTBC only because I've no experience with how blocks are defined in code, so didn't a proper review on that part.
Comment #4
robertDouglass CreditAttribution: robertDouglass commentedLooks good to me. We'd better add this - I'm scared of what will happen if Eaton starts using autocomplete on us.
Comment #5
dmitrig01 CreditAttribution: dmitrig01 commentedWell it seems Robert, JerkaRybka, and now I have reviewed it, so it better be RTBC or we'll get the actions unleashed apon us
Comment #6
eaton CreditAttribution: eaton commentedAn interesting side note. This means that theme developers interested in promoting themselves with a "Designed by so-and-so" blurb can stick that stuff in an overridden theme_system_powered_by(); It would never show up for folks who've already decided they don't want the promotional block.
Comment #7
Gábor HojtsyI like how this looks, especially with the interesting side note :) But I think Dries should definitely look at this.
Comment #8
FiReaNGeL CreditAttribution: FiReaNGeL commentedUsing the alt and title tag 'Powered by Drupal CMS' or 'Powered by Drupal, the open-source content management system' would be better from a SEO perspective. Currently Joomla ranks higher than Drupal on 'CMS', 'open source CMS' and 'Content management system' in Google. Just a little consideration that can have a big impact.
Comment #9
merlinofchaos CreditAttribution: merlinofchaos commentedGreat idea! We shouldn't be ashamed to promote ourselves.
Comment #10
catchlink juice version then.
alt and title both say:
as per FiReaNG3L. Makes sense to me.
Comment #11
Dries CreditAttribution: Dries commentedI think this is a good idea.
1. 'Drupal Project' should be 'Drupal project'.
2. We should specify
'external' => TRUE
.3.
$form['wrapper']['badge']
should probably be$form['wrapper']['color']
?4. The text "The Powered by Drupal" should probably use quotes or the em-tag.
Comment #12
Gábor HojtsyComment #13
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedI can not see why this should go into D6.
It is a new feature, and new features belong in the next version once HEAD is open for development again.
This does really belong to D7, and certainly this late in the release cycle. People get frustrated (incl. me) because of big/great features (improve image handling, database replication api, delete api, whatever) are getting postponed to D7 (when code freeze was there), and this kind of things are getting in so easily?
I would really like to set this postponed to D7.
Comment #14
gregglesHere is a patch which addresses all of Dries' concerns.
Thanks to Heine for noting the difference between "the" and "an". I also modified the alt/title text to say "Powered by Drupal, an open source content management system" since Drupal is just one of them, the "the". That language is consistent with the text we have on the home page of Drupal.org.
Comment #15
eaton CreditAttribution: eaton commentedTested it and it looks good. If it doesn't go into D6 I won't cry -- but it is a minor 'promotional/advertising' patch along the lines of SEO optimization. I group this in the UI/tweaks category rather than 'feature addition'.
Comment #16
Gábor HojtsyStefan, the changes you mention are *big* sweeping changes. We are adding some smaller cosmetic changes to improve the system and stabilizing what is there. Let's discuss this elsewhere if you have some examples which you think are of similar scale or which you think was unfair to get in in any way.
Committed.
Comment #17
(not verified) CreditAttribution: commented