Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As the title says.
Comment | File | Size | Author |
---|---|---|---|
#1 | 1832258-1_missing_word-do-not-test.patch | 1.1 KB | kotnik |
Comments
Comment #1
kotnik CreditAttribution: kotnik commentedFix attached.
Comment #2
Lars Toomre CreditAttribution: Lars Toomre commentedChange makes sense.
Comment #3
jhodgdonLooks fine, thanks! Normally I would say I wouldn't commit a patch that hasn't been run through the test bot (you should not have put the -do-not-test suffix on the file name), but since it's a one-line documentation fix, I'll make an exception in this case (pretty clear it does not introduce a PHP problem). I'll get it committed shortly.
Comment #4
Lars Toomre CreditAttribution: Lars Toomre commented@jhodgdon -- Slightly off-topic -- I am unsure of our current policy regarding classes referenced in a docblock like this one. Are we supposed to start them with a fully qualified '\' or leave them as is?
Comment #5
jhodgdonLars: http://drupal.org/node/1354#namespaces -- that issue is going to require some patching but not until after feature freeze (Dec 1).
Comment #6
webchickNice catch!
Committed and pushed to 8.x. Sorry, Jennifer, I was looking for something easy to do at 2:30am. ;)
Comment #7
jhodgdonUm. So first you apologize when you assign me issues to commit, and now you apologize for committing a patch that I would have had to commit? What's up with that? :)
Which is to say: no apology necessary! I have *plenty* of backlog, since I haven't done any commits for about 6 days now. The important thing is to get these patches committed... speaking of which...
Comment #8
webchickWell, I am Canadian, you know. :D