Tokens not substituted in breadcrumb

A similar patch needs to be applied to the views_get_url() function beginning around line 710 for the iCal feed to have the proper URL on OG Calendar views.

views_bookmark will soon be implementing this url_token. reviews are needed here.

Subscribing

subscribing

IS there any argument handling code required to make this work? I used this patch but not sure this is working. How can I verify it is working?

Does this apply to "$group" token as well in URL? I applied the patch hoping this fix this issue
http://drupal.org/node/257088

with no luck. Still the $group is not substitued correctly in URL.

Atleast one more person other than me confirmed (http://drupal.org/node/201718) the patch does not work for $group token.

I fixed it for calendar with this patch:
http://drupal.org/node/239594

I just used "$arg" as argument as a workaround, instead of this patch (since patch did not work for me) and it worked.

As superkc9 mentioned a change in function views_get_url was required. This is a cumulative patch which combines both the patch by KarenS above and changes to views_get_url
(my first multiline patch at drupal.org, so please guide me if I have done something wrong)

@KarenS Thanks for the issue with using $arg instead of $group. The patch I submitted above now takes care of it. Atleast it took care of it for me unless I missed something. Appreciate your comments.

I added some lines, due to missing replacement. For example for /node/$node-nodetype/list only $node was replaced, instead of $node-nodetype.

foreach ($tokens as $token) {
          if ($where = strpos($url, $token)){
			$to = strpos($url,"/",$where);
			$to = ($to)?$to-$where:strlen($url)-$where;
            break;
          }
      }
      if ($where){
          $url = substr_replace($url, $arg, $where, $to);
      } else {
          $url .= "/$arg";
      }

Complete patch attached!

Nice, and to fix the 'next' and 'prev' links in calendar views, see: http://drupal.org/node/239594

Last patches violate coding standards (wrong indentation). Please re-roll.

Here is the patch from #13, but properly formatted. I created this patch off of Views 5.x-1.6

Rerolled patch from #16 against current dev-- fixes the problem and works great with $arg and $group as arguments. Should be good to go.

At this time, only security fixes will be made to the 5.x version of Views.