Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The breadcrumb is not right when you use tokens like '$node' or '$user' in the url. We've added a hook to create $group for OG groups and that comes through literally as '$group' in the breadcrumbs, and I see the same problem when using anything but '$arg' in the url.
I found a method that will correct this. Patch attached.
Comment | File | Size | Author |
---|---|---|---|
#17 | views-183191-v2.patch | 2.01 KB | WorldFallz |
#16 | views-183191-16.patch | 1.88 KB | pathfinderelite |
#13 | views.module_183191.patch | 2.11 KB | derhasi |
#11 | views.module_32.patch | 1.99 KB | ajayg |
views.module_32.patch | 1.27 KB | KarenS | |
Comments
Comment #1
KarenS CreditAttribution: KarenS commentedBump. This patch is needed for OG calendar views to work correctly.
Comment #2
kc1981 CreditAttribution: kc1981 commentedA similar patch needs to be applied to the views_get_url() function beginning around line 710 for the iCal feed to have the proper URL on OG Calendar views.
Comment #3
moshe weitzman CreditAttribution: moshe weitzman commentedviews_bookmark will soon be implementing this url_token. reviews are needed here.
Comment #4
will_in_wi CreditAttribution: will_in_wi commentedSubscribing
Comment #5
ajayg CreditAttribution: ajayg commentedsubscribing
Comment #6
ajayg CreditAttribution: ajayg commentedIS there any argument handling code required to make this work? I used this patch but not sure this is working. How can I verify it is working?
Does this apply to "$group" token as well in URL? I applied the patch hoping this fix this issue
http://drupal.org/node/257088
with no luck. Still the $group is not substitued correctly in URL.
Atleast one more person other than me confirmed (http://drupal.org/node/201718) the patch does not work for $group token.
Comment #7
ajayg CreditAttribution: ajayg commentedComment #8
will_in_wi CreditAttribution: will_in_wi commentedI fixed it for calendar with this patch:
http://drupal.org/node/239594
Comment #9
ajayg CreditAttribution: ajayg commentedI just used "$arg" as argument as a workaround, instead of this patch (since patch did not work for me) and it worked.
Comment #10
KarenS CreditAttribution: KarenS commented$arg will work but you'll lose the special processing $group gives you -- $group checks if the node is a group node or not so the tab is only attached to group nodes. If you use $arg you'll see a tab on every node.
I haven't had time yet to look at the Calendar patch, but I'll get to it soon.
Comment #11
ajayg CreditAttribution: ajayg commentedAs superkc9 mentioned a change in function views_get_url was required. This is a cumulative patch which combines both the patch by KarenS above and changes to views_get_url
(my first multiline patch at drupal.org, so please guide me if I have done something wrong)
Comment #12
ajayg CreditAttribution: ajayg commented@KarenS Thanks for the issue with using $arg instead of $group. The patch I submitted above now takes care of it. Atleast it took care of it for me unless I missed something. Appreciate your comments.
Comment #13
derhasi CreditAttribution: derhasi commentedI added some lines, due to missing replacement. For example for
/node/$node-nodetype/list
only$node
was replaced, instead of$node-nodetype
.Complete patch attached!
Comment #14
dugh CreditAttribution: dugh commentedNice, and to fix the 'next' and 'prev' links in calendar views, see: http://drupal.org/node/239594
Comment #15
sunLast patches violate coding standards (wrong indentation). Please re-roll.
Comment #16
pathfinderelite CreditAttribution: pathfinderelite commentedHere is the patch from #13, but properly formatted. I created this patch off of Views 5.x-1.6
Comment #17
WorldFallz CreditAttribution: WorldFallz commentedRerolled patch from #16 against current dev-- fixes the problem and works great with $arg and $group as arguments. Should be good to go.
Comment #18
esmerel CreditAttribution: esmerel commentedAt this time, only security fixes will be made to the 5.x version of Views.