Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
So, for the new Data display type (#1819760: Add a REST export display plugin and serializer integration.) and probably feeds, we don't actually use area plugins, a.k.a, header, footer, and no results behaviour.
So let's make it possible to disable these for a display plugin. I have copied how we currently deal with the fields category of the UI, displaying a message saying 'The selected display type does not utilize @type plugins'.
Comment | File | Size | Author |
---|---|---|---|
#13 | usesAreas-screenshot.png | 84.37 KB | damiankloip |
#11 | 1829424-11.patch | 6.79 KB | damiankloip |
#9 | 1829424-9.patch | 6.81 KB | damiankloip |
#6 | 1829424-6.patch | 5.68 KB | damiankloip |
#4 | drupal-1829424-4.patch | 4.55 KB | dawehner |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedComment #2
dawehnerMaybe this test function could have some more documentation what is going on.
What odd class urg!!
Does it make sense to use format_string instead?
Comment #3
damiankloip CreditAttribution: damiankloip commentedThanks for the comments; I added some docs in the test. I am not using format string as I am just asserting the actual strings in the UI, not for a message.
Comment #4
dawehnerJust renamed the $name variable in the test to $class.
Comment #5
tim.plunkettI think the doc should be moved from the top to the bottom
Otherwise it looks good.
Comment #6
damiankloip CreditAttribution: damiankloip commentedThanks, fixed that, and also added the missing DisplayNoAreaTest file so this will actually pass.
Comment #8
dawehnerYou should probably post some screenshots about the change!
Comment #9
damiankloip CreditAttribution: damiankloip commentedRerolled and fixed based on #1798574: Refactor Views UI to be a form controller. Tim provided a fix for the UI form rendering.
Comment #10
damiankloip CreditAttribution: damiankloip commentedComment #11
damiankloip CreditAttribution: damiankloip commentedJust removed the $text variable from the test and cast the element value directly.
Comment #12
dawehnerYeah for making code a bit simpler.
Comment #13
damiankloip CreditAttribution: damiankloip commentedHere is a screenshot of what it achieves on the area plugins in the UI.
Comment #14
webchickCommitted to 8.x. I'm going to rebase and push when I'm done with this current commit spree.