If you try to use reset on an exposed form, you get a redirect loop... uh oh.

First things first, here are some tests for it. So should fail to start with as there is no fix yet.

The patch also changes the base class to UITestBase, so it then creates admin users for us.

EDIT: Oh and I changed the yaml file name for the test view from test_rename_reset_button to test_reset_button.

CommentFileSizeAuthor
#3 1826008-3.patch4.45 KBdamiankloip
views-reset-button-tests.patch3.85 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, views-reset-button-tests.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

#1807916: Reset button on exposed filters causes a redirect loop seems to be the related issue.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
1826008-3.patch4.45 KB

Let's add the small fix from over there (link from #2), to here. Then we *should* have a passing test...

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

We have tests, we have a fix which works for people in d7 already and we have a proper looking code.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Looks fine. Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.