Please change the DEFINE to

define('MAIL_LINE_ENDINGS', isset($_SERVER['WINDIR']) ||
(array_key_exists('SERVER_SOFTWARE',$_SERVER) &&
strpos($_SERVER['SERVER_SOFTWARE'], 'Win32')) !== FALSE ? "\r\n" : "\n");

strpos returns correct but as the index does not exist it give error message.

CommentFileSizeAuthor
#6 mail.inc_.patch578 bytesadixon

Comments

arne_hortell’s picture

arne_hortell commented
Version: 7.x-1.6 » 7.x-1.17

This bug is still there.

ziobudda’s picture

ziobudda commented

This bug is still here and it creates a FATAL ERROR if I install nodejs integration module watchdog submodule.

arne_hortell’s picture

arne_hortell commented

Thanks all you people keeping drupal.org working!!!

arne_hortell’s picture

arne_hortell commented

Still same issue, my fix works though...

arne_hortell’s picture

arne_hortell commented
Version: 7.x-1.17 » 7.x-2.23

Still same error, see my fix above.

adixon’s picture

adixon commented
StatusFileSize
new mail.inc_.patch578 bytes

Yes, I have this also. A version of the arne's patch attached.

I'm curious why this hasn't had more attention. My guess is that it only shows up when a cron task tries to send mail (and I'm seeing it when it's being triggered via a CiviCRM cron).

In any case, seems straightforward, though it'd be nice if all this 'windows-specific overrides' ended up in it's own file somewhere.

arne_hortell’s picture

arne_hortell commented
Issue summary: View changes

Still not fixed in core, patch works

manuel garcia’s picture

manuel garcia commented
Project: Mail System » Drupal core
Version: 7.x-2.23 » 7.x-dev
Component: Code » mail system
Status: Active » Closed (duplicate)

This was always meant for Drupal core, not mailsystem module.

Closing as duplicate because this was already fixed on #2356055: Notice in includes/mail.inc define