Closed (fixed)
Project:
Lightbox2
Version:
5.x-2.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
11 Oct 2007 at 00:15 UTC
Updated:
21 Dec 2007 at 15:55 UTC
You might or might not know that imagecache, since recently, also supports private downloads and unclean URLs.
That means that imagecache URLs may not only be in the form "[filedir]/imagecache/..." but also in the form "system/files/imagecache/...", for both clean and unclean URLs. Which in turn means that it would be a good thing to use file_create_url() everywhere in the formatter, including the link to the original image in l(). And as l() also copes with external URLs like the ones generated by file_create_url(), it should be absolutely no problem to wrap file_create_url() around the filepath.
Please review, and if possible apply, the attached one-liner. Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| lightbox2-all-imagecache-download-methods.patch | 640 bytes | jpetso |
Comments
Comment #1
stella commentedFixed in CVS and will be included in the next release. Thanks for the patch.
Cheers,
Stella
Comment #2
(not verified) commentedComment #3
stella commentedReleased in Lightbox V2 5.x-2.2.
Cheers,
Stella