Files: 
CommentFileSizeAuthor
#6 1824854-cmi-drupal_stale_file_threshold-6.patch1.36 KBcam8001
PASSED: [[SimpleTest]]: [MySQL] 46,310 pass(es).
[ View ]
#6 interdiff.txt506 bytescam8001
#5 1824854-cmi-drupal_stale_file_threshold-5.patch1.36 KBcam8001
PASSED: [[SimpleTest]]: [MySQL] 46,320 pass(es).
[ View ]
#3 1824854-cmi-drupal_stale_file_threshold-3.patch1.47 KBcam8001
PASSED: [[SimpleTest]]: [MySQL] 46,232 pass(es).
[ View ]
#3 interdiff.txt441 bytescam8001
#2 1824854-cmi-drupal_stale_file_threshold.patch1.47 KBcam8001
PASSED: [[SimpleTest]]: [MySQL] 46,235 pass(es).
[ View ]

Comments

cam8001’s picture

Title:Convert variable drupal_stale_file_threshold to state system» Convert variable drupal_stale_file_threshold to CMI system
cam8001’s picture

Status:Active» Needs review
Issue tags:+State system
StatusFileSize
new1.47 KB
PASSED: [[SimpleTest]]: [MySQL] 46,235 pass(es).
[ View ]

Candidate patch attached. Couple of things:

- New state name is `system.stale_file_threshold`, but I'm not sure this is the best name. It might be better to put it in the file namespace, maybe?
- I've added a general purpose update hook to convert variables to the state system. I'm not sure if this is within the scope of the patch, but at the least it will convert any saved `drupal_stale_file_threshold` values to state.

cam8001’s picture

StatusFileSize
new441 bytes
new1.47 KB
PASSED: [[SimpleTest]]: [MySQL] 46,232 pass(es).
[ View ]

Woops, had a bad name on the update hook.

Berdir’s picture

Status:Needs review» Needs work

Should use the new helper function for the upgrade now.

cam8001’s picture

Status:Needs work» Needs review
StatusFileSize
new1.36 KB
PASSED: [[SimpleTest]]: [MySQL] 46,320 pass(es).
[ View ]

New patch with variable as config instead of state.

cam8001’s picture

StatusFileSize
new506 bytes
new1.36 KB
PASSED: [[SimpleTest]]: [MySQL] 46,310 pass(es).
[ View ]

Duh, wrong config key.

Berdir’s picture

Status:Needs review» Reviewed & tested by the community

RTBC if it passes the tests.

catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.