We use the tag 'kernel.event_subscriber' for registering subscriber services that need to be added to the event dispatcher. While most of the events that will get dispatched by our 'dispatcher' service will be kernel events, we'll also be using the same tag for other non-kernel-related events. So it makes sense to rename it to simply 'event_subscriber'.
This should be a simple find and replace (affecting services registered in core/lib/Drupal/Core/CoreBundle.php and the compiler pass itself in core/lib/Drupal/Core/DependencyInjection/Compiler/RegisterKernelListenersPass.php).

Any takers? :-)

CommentFileSizeAuthor
#1 issue-1824400-01-event_subscriber.patch5.21 KBgapple
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gapple’s picture

Status: Active » Needs review
FileSize
5.21 KB

Here is a quick find-replace patch

katbailey’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looks simple enough.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.