There's a method NodeBlocktest::testSearchFormBlock() which actually tests the syndicate block, not the search form block. It really should be renamed. This is in core/modules/node/lib/Drupal/node/Tests/NodeBlockTest.php.

CommentFileSizeAuthor
#9 confusing_name-1824016-9.patch644 bytesdermario
#6 confusing_name-1824016-6.patch746 bytesdermario
#2 confusing_name-1824016-2.patch746 bytesdermario

Comments

dermario’s picture

dermario
Primary language German
Location Zürich
commented
Assigned: Unassigned » dermario

Let me give a try to fix it.

dermario’s picture

dermario
Primary language German
Location Zürich
commented
Status: Active » Needs review
StatusFileSize
new confusing_name-1824016-2.patch746 bytes

I renamed the method to

function testSyndicateBlock() {
..
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

That seems like a much more reasonable name. Thanks! This should be fine assuming the test bot agrees.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Uh, yes! Those two things aren't the same thing at all, are they? :)

Committed and pushed to 8.x. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

Actually, it looks like this one could use a backport to d7 -- node.test has the NodeBlockTestCase class with the same method name in it.

dermario’s picture

dermario
Primary language German
Location Zürich
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new confusing_name-1824016-6.patch746 bytes

I fixed that for d7 too. Created that patch on 7.x-dev version.

Status: Needs review » Needs work

The last submitted patch, confusing_name-1824016-6.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

That's not a 7.x patch -- there is no core directory in 7.x.

dermario’s picture

dermario
Primary language German
Location Zürich
commented
Status: Needs work » Needs review
StatusFileSize
new confusing_name-1824016-9.patch644 bytes

Yes obviously i was wrong. I am still learning git but i should have seen that by myself. Heres another patch for d7.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: dermario » jhodgdon
Status: Needs review » Reviewed & tested by the community

Thanks! That patch looks right to me. I'll get it committed this week (avoiding non-essential core commits this week due to a big Views sprint going on).

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks! 7.x is now one word clearer. :) Oops. I guess this wasn't strictly documentation, but it's a clean-up and backport of a committed 8.x patch. Hope it's OK that I committed it. ...

Automatically closed -- issue fixed for 2 weeks with no activity.