Through #1748176-25: Add test coverage for Views user integration. When we use the contextual filters (uid) in the title of one views we get one error for anonymous users. We get Uncategorized instead of the name of anonymous user.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | interdiff.txt | 3.41 KB | olli |
| #9 | 1823398-9.patch | 4.18 KB | olli |
| #8 | interdiff.txt | 2.7 KB | olli |
| #8 | 1823398-8.patch | 2.68 KB | olli |
| #3 | 1823398-3-tests-only.patch | 760 bytes | damiankloip |
Comments
Comment #1
fastangel commentedI attached a new patch for this special case.
Comment #2
damiankloip commentedThis needs some tests added to the ones provided by the referenced issue above then I guess.
Comment #3
damiankloip commentedSo, maybe we don't need the title override, but the currently patch will not work anyhow.
Not totally sure about this approach, but we could add the anonymous user to the views_data definition, then the current logic will take care of this for us anyway.
Validation welcome.
Comment #4
dawehnerDo we then still require the code in the actual argument handler?
Comment #5
damiankloip commentedWe just have the overriden title_query() method left. Won't we need that for multiples?
Comment #6
dawehner#3: 1823398-3.patch queued for re-testing.
Comment #8
olli commentedReroll.
1. Added test for multiples
2. Removed the anonymous code from argument handler
Comment #9
olli commentedInjected the user storage controller.
Is there an issue to add a generic entity id argument handler?
Comment #10
dawehnerJust in case you have to reroll it again, change that to \Drupal::config()..., as we now not longer call the container like that in tests.
Comment #11
xano9: 1823398-9.patch queued for re-testing.
Comment #12
alexpottCommitted f22264a and pushed to 8.x. Thanks!