They are too large, per the attached sreenshot.

CommentFileSizeAuthor
#14 recent-activity-picture.png136.73 KBrosemeria
#9 1823318.user_avatar_image_style_tokens.patch4.48 KBjpontani
#7 1823318.commons_activity_stream.user_picture_style_tokens.patch4.48 KBjpontani
commons_image_style.png155.67 KBezra-g

Comments

ezra-g’s picture

ezra-g commented

And the sitewide contributors block should use larger images.

ezra-g’s picture

ezra-g commented
Issue tags: +commons-7.x-3.0-beta1

Tagging for Beta1.

ezra-g’s picture

ezra-g commented
Title: Activity stream and node teaser thumbnails should use smaller image style » Activity stream, contributor and node teaser thumbnails should use smaller, square image style
Issue tags: -commons-7.x-3.0-beta1

See #1868250: User pictures in Contributors block need better proportions for an example of why this is important.

jpontani’s picture

jpontani commented
Assigned: Unassigned » jpontani
japerry’s picture

japerry
Location KOMK
commented
Status: Active » Fixed

Not sure when it happened, but this is fixed!

ezra-g’s picture

ezra-g commented
Status: Fixed » Active

These are currently being styled by the theme, not an image style. As a result, we're sending extra data over the pipe.

jpontani’s picture

jpontani commented
Status: Active » Needs review
StatusFileSize
new 1823318.commons_activity_stream.user_picture_style_tokens.patch4.48 KB

Attached a patch that adds tokens for user picture using image styles that are available. The patch also changes the default messages included in activity streams feature to use 35x35 image style.

ezra-g’s picture

ezra-g commented
Issue tags: +Commons 7.x-3.2 radar

Let's review for 3.2.

jpontani’s picture

jpontani commented
StatusFileSize
new 1823318.user_avatar_image_style_tokens.patch4.48 KB

Patch re-roll, as the previous patch no longer applies.

jpontani’s picture

jpontani commented
Status: Needs review » Needs work

Activity stream pictures now use 35x35 image style.

http://drupalcode.org/project/commons_activity_streams.git/commit/7ce0c86

Still need to change contributor and node creator images.

jpontani’s picture

jpontani commented

hook_update_N implementation to revert the message types. Makes sure the new image styles are taken into account.

http://drupalcode.org/project/commons_activity_streams.git/commitdiff/69...

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Fixed

looks good to me!

rosemeria’s picture

rosemeria commented

Message when a wiki page has been updated on activity stream-- needs square 35 x 35 picture fix too.
Thanks

rosemeria’s picture

rosemeria commented
StatusFileSize
new recent-activity-picture.png136.73 KB

User image in activity stream formatted differently for "wiki updates" img class="image-style-thumbnail" should be 35x35. You can only catch this minor design issue if user profile picture uploaded is not square.

user picture issue

jpontani’s picture

jpontani commented
Title: Activity stream, contributor and node teaser thumbnails should use smaller, square image style » Wiki activity stream message user picture needs to be 35x35 image style
Status: Fixed » Needs work

Retitling

jpontani’s picture

jpontani commented
Status: Needs work » Fixed

Committed.

http://drupalcode.org/project/commons_wikis.git/commitdiff/a4c5ad7

Automatically closed -- issue fixed for 2 weeks with no activity.