Currently there are comments in comment handling in NodeLink which is pretty old.
+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NodeLink.phpundefined @@ -0,0 +1,57 @@ + // Call comment.module's hook_link: comment_link($type, $node = NULL, $teaser = FALSE) + // Call node by reference so that something is changed here + comment_node_view($node, $this->options['teaser'] ? 'teaser' : 'full'); + // question: should we run these through: drupal_alter('link', $links, $node); + // might this have unexpected consequences if these hooks expect items in $node that we don't have? + + // Only render the links, if they are defined. + return !empty($node->content['links']['comment']) ? drupal_render($node->content['links']['comment']) : '';All these comments relate to Drupal 6, and not the actual code here.
The issue is all about clean up this file.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 1817638-6.patch | 1.09 KB | fastangel |
| #1 | 1817638.patch | 1.02 KB | damiankloip |
Comments
Comment #1
damiankloip commentedComment #2
dawehnerThis code is looking great, though it will lead to merge problems on the sandbox.
Comment #3
xjmComment #4
fastangel commentedNot is need reroll this patch because this code only affect comment module.
Comment #5
xjmNo, the patch above does not apply. It needs to be rerolled against comment module's views integrations, which were ported and moved into
core/modules/comment.Comment #6
fastangel commentedRerolled.
Comment #7
dawehnerThis looks perfect now
Comment #8
webchickCommitted and pushed to 8.x. Thanks!