Currently there are comments in comment handling in NodeLink which is pretty old.

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NodeLink.phpundefined
@@ -0,0 +1,57 @@
+	// Call comment.module's hook_link: comment_link($type, $node = NULL, $teaser = FALSE)
+	// Call node by reference so that something is changed here
+	comment_node_view($node, $this->options['teaser'] ? 'teaser' : 'full');
+	// question: should we run these through:	drupal_alter('link', $links, $node);
+	// might this have unexpected consequences if these hooks expect items in $node that we don't have?
+
+	// Only render the links, if they are defined.
+	return !empty($node->content['links']['comment']) ? drupal_render($node->content['links']['comment']) : '';

All these comments relate to Drupal 6, and not the actual code here.

The issue is all about clean up this file.

Files: 
CommentFileSizeAuthor
#6 1817638-6.patch1.09 KBfastangel
PASSED: [[SimpleTest]]: [MySQL] 46,193 pass(es). View
#1 1817638.patch1.02 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 3,149 pass(es). View

Comments

damiankloip’s picture

Status: Active » Needs review
FileSize
1.02 KB
PASSED: [[SimpleTest]]: [MySQL] 3,149 pass(es). View
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This code is looking great, though it will lead to merge problems on the sandbox.

xjm’s picture

Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
fastangel’s picture

Status: Needs work » Reviewed & tested by the community

Not is need reroll this patch because this code only affect comment module.

xjm’s picture

Status: Reviewed & tested by the community » Needs work

No, the patch above does not apply. It needs to be rerolled against comment module's views integrations, which were ported and moved into core/modules/comment.

fastangel’s picture

Status: Needs work » Needs review
FileSize
1.09 KB
PASSED: [[SimpleTest]]: [MySQL] 46,193 pass(es). View

Rerolled.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

This looks perfect now

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.