Apply first/last classes in more logical places [#181564]

My themers ask me for first/last classes on things on a constant basis. primary/secondary links already have them, but other lists don't. Attached patch adds first/last classes to all theme_item_list lists as well as to all menu block lists. It's just extra hooks for themers to play with.

Comment	File	Size	Author
#6	notices_9.patch	642 bytes	webernet
#6
#2	firstlast_0.patch	3.4 KB	Crell
#2
	firstlast.patch	4.07 KB	Crell

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yched CreditAttribution: yched commented 7 October 2007 at 22:56

Ooh yes, +1.
The parts that affect menu_local_tasks() seem unneeded ?

Comment #2

Crell CreditAttribution: Crell commented 7 October 2007 at 23:32

File	Size
firstlast_0.patch	3.4 KB

Indeed, that's because they are. :-) I had tried to add first/last there as well, but gave up because that function scares me.

Comment #3

yched CreditAttribution: yched commented 8 October 2007 at 00:07

Status:

Needs review

» Reviewed & tested by the community

ready then...

Comment #4

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 8 October 2007 at 14:15

Status:

Reviewed & tested by the community

» Fixed

Good idea, good code, committed.

Comment #5

webernet CreditAttribution: webernet commented 8 October 2007 at 14:38

Status:

Fixed

» Needs work

This patch introduced the following notices on admin/build/modules

* notice: Undefined variable: items in /includes/menu.inc on line 596.
* notice: Undefined variable: items in /includes/menu.inc on line 597.
* warning: Invalid argument supplied for foreach() in /includes/menu.inc on line 597.