Your fork of sqlsrv project is genius idea! :)
I'm using it for Feeds and SELECT statements only so I don't know if it's working for everyting but still this is fantastic.

One thing I had to change to make it work:

CommentFileSizeAuthor
#5 bad_separator-1815328-5.patch905 bytesdeadbeef
#1 dblib_port_after_colon_2.patch551 bytesphilipz
dblib_port_after_colon.patch551 bytesphilipz

Comments

philipz’s picture

philipz commented
StatusFileSize
new dblib_port_after_colon_2.patch551 bytes

A colon not a semicolon of course:

paddy_deburca’s picture

paddy_deburca commented

Philip, the fix is not as simple as this. I believe that the comma works on MS Windows (http://www.php.net/manual/en/ref.pdo-dblib.php#66917), whereas the colon is necessary for *nix.

It may be necessary to define a DB_PORT_SEPARATOR that is either a comma or a colon depending on the architecture, and using that constant rather than hard coding a comma or colon in the host option.

Paddy.

philipz’s picture

philipz commented

This is a good idea to implement it like that.
From various sources I found you could check for OS like that:

if (strncasecmp(PHP_OS, 'WIN', 3) == 0) {
    echo 'Windows!';
} else {
    echo 'Not Windows!';
}

BTW since my last comment I've been using your driver also with Migrate module and it's been working great.

amontero’s picture

amontero
Location Barcelona
commented

Happened to me, too. Kept me busy for some time until found it:
http://us1.php.net/manual/en/ref.pdo-dblib.connection.php#88703

The main reasoning for using this module is using it from OS other than Windows. Should not this be warned in the project page, if not left by default as colon in the code?

deadbeef’s picture

deadbeef commented
Issue summary: View changes
StatusFileSize
new bad_separator-1815328-5.patch905 bytes

Here's a patch that should apply with git and set the separator depending on OS