Closed (fixed)
Project:
Facet API
Version:
6.x-3.x-dev
Component:
Current Search Blocks
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Oct 2012 at 00:58 UTC
Updated:
15 May 2013 at 15:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
jhedstromAttached patch adds this hook.
Comment #2
pwolanin commentedLooks reasonable - let me test locally.
Comment #3
cpliakas commentedThis patch definitely works as intended, however the Current Search blocks do not :-(. Therefore I am marking as needs work for that reason since we do have to fix the underlying issues prior to committing the fix, otherwise people will get fatal errors.
Specifically, the error I am getting is Call to a member function fetchField() on a non-object in sites/all/modules/contrib/facetapi/contrib/current_search/current_search.block.inc on line 45
Anyways, thanks for the contribution and flushing out this use case!
Chris
Comment #4
jhedstromI probably won't have a chance to take this the rest of the way, but my findings were that the ctools plugin hooks aren't fully implemented (eg, key classes are not found and loaded as intended).
Comment #5
n.dhuygelaere commentedIf it can help, i have make some changes in facetapi and current_search for make it work on Drupal 6.19 with postgres database and solr (module 6.3.x).
If you can test.
Comment #6
zerolab commentedAttaching a patch with correct ctools plugin hooks, hook_block() implementation and proper D6 form elements for the settings form.
Needs some additional testing. More eyes are better than two.
Best,
Dan
Comment #7
zerolab commentedComment #8
voidberg commentedThe patch in #6 was a good start but it did not work for me: tokens were not being replaced, did not show up on admin forms, lots of warnings regarding arrays sent instead of strings etc. I am attaching a modified version with the following changes:
- Added token as a dependency to current_search.
- Backported token code to token 6.
- Replaced default token definitions to be token 6 compatible.
- Removed Drupal 7 function calls.
- Changed class attributes to strings instead of arrays as drupal_attributes does not work with arrays in Drupal 6.
We're using this in production with no issues so far.
Comment #9
cpliakas commentedI haven;t tested the patch, but given the state of the existing code it is way better than where we are at now so I am in favor of committing it even if it isn't perfect (which it very well could be :-)).
Thanks for the contribution,
Chris
Comment #10
DaPooch commentedPatch #8 is working for me (sort of) but I had to add an include to the /contrib/current_search/plugins/current_search/item_text.inc file before the class declaration since I was getting an error that "Class 'CurrentSearchItem' not found in item_text.inc on line 11"
require_once('item.inc')Comment #11
voidberg commentedCommited to 6.3 version of Facet API.
http://drupalcode.org/project/facetapi.git/commit/b6178ac
http://drupalcode.org/project/facetapi.git/commit/4b57b48
Comment #12
cpliakas commentedGreat work. Thanks!
Comment #13
rares commentedupgrading from 6.x-3.0-beta2 to -dev also fixed this for me. As far as I'm concerned, the -beta2 is unusable without these fixes, as the admin pages are not displaying properly (no item settings, no advanced settings, no save configuration button)