Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
$form_state['clicked_button'] has been deprecated in D7 in favor of $form_state['triggering_element'].
Time to remove it.
Comment | File | Size | Author |
---|---|---|---|
drupal8.form-clicked-button-remove.0.patch | 1.88 KB | sun | |
Comments
Comment #1
tstoecklerLooks good. Grepping for 'clicked_button' yields a couple more results, but none are actually using $form_state['clicked_button']. An example from file.module:
$clicked_button = end($form_state['triggering_element']['#parents']);
Whether we want to "clean that up" or not (I'm not entirely sure that it's actually incorrect) I think can be a follow-up.
Guess, this needs a change notification, even if it was deprecated in D7.
Comment #2
sunyeah, there are remaining instances of the string "clicked_button" in file.module and also Form API tests, but those are fine, as long as no code is using $form_state['clicked_button'].
Comment #3
catchYep. Committed/pushed to 8.x.
Wonder how many @deprecated are left at the moment.
Comment #4
sunCreated #1813760: [meta] Clean up @todos and deprecated code
Comment #5
tstoecklerAdded a change notice.