Bad value 0 for attribute size on element select [#1812080]

This is the source code of an address field from address field module. I'm not sure why there is a 0 in the size field (may be a bug), but should we fix such issues here?

Validation error:
line 248 column 131 - Error: Bad value 0 for attribute size on element select: Zero is not a positive integer.

Code example:

<select size="0" name="field_address[und][0][country]" id="edit-field-address-und-0-country" class="country form-select required ajax-processed">
<option value="AF">Afghanistan</option><option value="AX">Aland Islands</option>
<option value="AL">Albania</option>
<option value="DZ">Algeria</option>
<option value="AS">American Samoa</option>
<option value="AD">Andorra</option>
</select>

Comment	File	Size	Author
#3	addressfield-select_size_value_0-1812080-3.patch	464 bytes	goron
#2	addressfield-select_size_value_0-1812080-2.patch	429 bytes	goron

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hass CreditAttribution: hass commented 15 May 2013 at 00:51

Project:	HTML5 Tools	» Address Field
Category:	feature	» bug

Moving to Address Field as I have found that a value of 0 is invalid per API docs http://api.drupal.org/api/drupal/developer%21topics%21forms_api_referenc...

Values: A positive number.

Per http://www.quackit.com/html_5/tags/html_select_tag.cfm

Specifies the number of options to show to the user. The value must be a valid non-negative integer greater than zero. If the multiple attribute is present, then the size attribute's default value is 4. If the multiple attribute is absent, then the size attribute's default value is 1.

Comment #2

goron CreditAttribution: goron commented 4 August 2013 at 00:28

Status:

Active

» Needs review

File	Size
addressfield-select_size_value_0-1812080-2.patch	429 bytes

I encountered this too. It can be a problem when formatting select elements, for instance with formalize.css.

This patch fixes the issue. Just removed one line. I'm not sure why that line was there in the first place, doesn't seem like it's needed for anything.

Comment #3

goron CreditAttribution: goron commented 4 August 2013 at 00:43

File	Size
addressfield-select_size_value_0-1812080-3.patch	464 bytes

I see now that the line was there to "cancel" the #size property that may have been set before on the element. But it should be unset rather than zeroed. Here's a new patch.