This is a sub-issue of #1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing* focused on correctly adding @param and @return type hinting to the Contact module.
Documentation patches that include type hinting are time consuming to both review and commit because one must dig into the actual code to confirm that the type hints are both correct and complete. Hence, please be patient and try to limit type hint patches to covering only a limited number of docblocks (20-25 as a guess).
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1811226_4.patch | 1.8 KB | mile23 |
Comments
Comment #1
lars toomre commentedMarking as postponed until #1811628: Further clean up of API docs for Contact module is committed.
Comment #1.0
lars toomre commentedUpdates reference to new Contact module follow-up issue.
Comment #2
mile23Comment #3
mile23#1811628: Further clean up of API docs for Contact module is fixed, and there are still type hinting issues in Contact, so this is active.
Comment #4
mile23Le patch.
Comment #5
jhodgdonThe changes in this patch are fine. Thanks! Committed to 8.x (beta fine: unfrozen documentation)