This is a sub-issue of #1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing* focused on correctly adding @param and @return type hinting to the Contact module.

Documentation patches that include type hinting are time consuming to both review and commit because one must dig into the actual code to confirm that the type hints are both correct and complete. Hence, please be patient and try to limit type hint patches to covering only a limited number of docblocks (20-25 as a guess).

Related sprint issues:

Sprint Topic Sub Issue
#1518116: [meta] Make Core pass Coder Review #1533112: Make Contact module pass Coder Review
#1310084: [meta] API documentation cleanup sprint #1811628: Further clean up of API docs for Contact module
#500866: [META] remove t() from assert message #1742830: Removing t() from asserts in simpletests in contact module
CommentFileSizeAuthor
#4 1811226_4.patch1.8 KBMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Status: Active » Postponed

Marking as postponed until #1811628: Further clean up of API docs for Contact module is committed.

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Issue summary: View changes

Updates reference to new Contact module follow-up issue.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Issue summary: View changes
Parent issue: » #1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing*
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Postponed » Active

#1811628: Further clean up of API docs for Contact module is fixed, and there are still type hinting issues in Contact, so this is active.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Active » Needs review
FileSize
1811226_4.patch1.8 KB

Le patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Fixed

The changes in this patch are fine. Thanks! Committed to 8.x (beta fine: unfrozen documentation)

  • jhodgdon committed 7ed8d75 on 8.0.x 
    Issue #1811226 by Mile23: Add missing type hinting to Contact module...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.