C:\xampp\htdocs\views\views_ui\admin.inc
     994    $display = &$view->display[$display_id];
    2143          $plugin->init($view, $view->display[$display_id], $handler->options['style']['options']);
2 matches in C:\xampp\htdocs\views\views_ui\admin.inc
CommentFileSizeAuthor
#14 views-1810826-13.patch6.08 KBtim.plunkett
#12 settings.png10.81 KBdawehner
#11 views-1810826-11.patch5.26 KBtim.plunkett
#11 interdiff.txt2.3 KBtim.plunkett
#10 1810826-10.patch3.17 KBfastangel
#8 views-1810826-5.patch3.1 KBdawehner
#5 views-1810826-5.patch3.1 KBxjm
#5 interdiff.txt531 bytesxjm
#2 views-1810826-2.patch2.71 KBdawehner
#1 views-1810826-1.patch910 bytesdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new views-1810826-1.patch910 bytes

One code was not used at all, so let's remove it.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new views-1810826-2.patch2.71 KB

Just realized that this function is not used anymore. The UI for summaries is included in arguments directly.

xjm’s picture

xjm
she/her
Primary language English
commented

grep shows the following references:

[lorentz:views | Fri 08:56:21] $ grep -r "views_ui_config_style_form" *
views_ui/admin.inc:      'form_id' => 'views_ui_config_style_form',
views_ui/admin.inc:function views_ui_config_style_form($form, &$form_state) {
views_ui/admin.inc:    $view->getStandardButtons($form, $form_state, 'views_ui_config_style_form');
views_ui/admin.inc:function views_ui_config_style_form_submit($form, &$form_state) {

That first one is in views_ui_ajax_forms(). Do we need to remove that entry for the form there?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work

Yes, it should be removed from views_ui_ajax_forms() as well.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt531 bytes
new views-1810826-5.patch3.1 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Nice! I like to have bugs turning into actual cleanups.

dawehner’s picture

dawehner
Primary language German
commented
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Reviewed & tested by the community » Needs review

Rerole against core.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new views-1810826-5.patch3.1 KB

With an actual patch.

Status: Needs review » Needs work

The last submitted patch, views-1810826-5.patch, failed testing.

fastangel’s picture

fastangel commented
Status: Needs work » Needs review
StatusFileSize
new 1810826-10.patch3.17 KB

Rerolled.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: admin.inc is passing display instead of displayHandler » Remove obsolete form code from views_ui/admin.inc
StatusFileSize
new interdiff.txt2.3 KB
new views-1810826-11.patch5.26 KB

This came up while I was working on #1798574: Refactor Views UI to be a form controller

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new settings.png10.81 KB

@tim
This is not a feature we can drop, see the attached screenshot

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Sorry i was wrong. config-type was used for the override button in d6.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new views-1810826-13.patch6.08 KB

Missed the calling code. @dawehner and I talked in IRC and this is fine.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

So finally!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yay less code! :D

Committed and pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.