Currently we have zero coverage for this function; It's pretty important and called alot.

CommentFileSizeAuthor
#1 views-1809608-1.patch2.11 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new views-1809608-1.patch2.11 KB

Let's start with the basic level

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +VDC
damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community 
+++ b/lib/Drupal/views/Tests/ViewsDataTest.phpundefined
@@ -49,4 +49,67 @@ class ViewsDataTest extends ViewTestBase {
+      $this->assertEqual($expected_keys, array_keys($fields), format_string('Make sure the handlers of type @handler_type are listed as expected.', array('@handler_type' => $handler_type)));

I would maybe change this to just say "Handlers of type @handler_type are listed as expected"

Otherwise, this look good.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Thank you for the review again! Committed to 8.x-3.x

Automatically closed -- issue fixed for 2 weeks with no activity.