Closed (fixed)
Project:
Image Exact Sizes
Version:
5.x-0.1
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Oct 2007 at 22:43 UTC
Updated:
7 Mar 2008 at 20:18 UTC
It's me again. (:
There are two operations with Image nodes that should invoke exact_size. One is 'insert', other is 'update'. Currently it is called at 'validate' operation which is incorrect.
Location: image_exact.module line 88
Wrong:
if ($node->type == 'image' && $op == 'validate' && variable_get('image_exact_thumbs', 1)) {
Right:
if ($node->type == 'image' && in_array($op, array('insert', 'update')) && variable_get('image_exact_thumbs', 1)) {
Please review
Thanks
Comments
Comment #1
Xigi commentedSorry it's 'submit' and not 'insert'.
So the right line is:
if ($node->type == 'image' && in_array($op, array('submit', 'update')) && variable_get('image_exact_thumbs', 1)) {
Thanks
Comment #2
joshk commentedapplied