Closed (fixed)
Project:
Configuration Management
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
10 Oct 2012 at 10:10 UTC
Updated:
30 Oct 2012 at 11:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
neoxavier commentedHere is the patch
Comment #2
dagmarComment #3
gdrupal commented@neoxavier First thanks for this great job you are doing... now the review:
There is a few indent issues about coding standard.
The callbacks works great when you have components to list.. but what happens if you do not have tracked or non tracked components?
We need to contemplate that use case.. some fallback message or something.
I will be posting a non related issue with menu-link components i have found reviewing you patch... really good job pretty close to close it ;)
Comment #4
neoxavier commentedah ya, sorry about that
thank you for the input. here is the simple fallback message
Comment #6
neoxavier commented#4: configuration-cgtandcgnt-1808450-4.patch queued for re-testing.
Comment #8
neoxavier commentedthere was merge conflict, hope this patch will resolve it
Comment #10
neoxavier commentedremoving white spaces,
hope this one works
Comment #11
neoxavier commentedput it to needs review
Comment #12
gdrupal commented@neoxavier the patch seems to we working fine for the cgt command but I getting a error when using cgnt and we are tracking all components, you are missing the fallback message there. Finally, we still have a lot of coding standard warnings, just as example there is much more than this:
I think you forgot to apply the auto-format to the code ;)
Comment #13
neoxavier commentedwhat this is weird, coder does not pickup anything.
which tools do you use? I think I need that.
here is the fix for cgnt and some fix on coding standard. But I am not really sure about the coding standard
Comment #14
gdrupal commented@neoxavier Now cgnt is working right ;) ... as for the coding standard, pretty close! i'm using coder.. just set it to "minor" in warnings options. Check this last 3 and we are good to go!
Comment #15
neoxavier commentedah ok,
hope this is the last one :)
Comment #16
gdrupal commentedNow i think RTBC ;)
Comment #17
dagmarSorry, but we have an API to do this, lets try to no re-write the code, because is harder to change later.
Same for this.
Comment #18
dagmarComment #19
dagmarAlso It will need a re-roll, I committed 4 new patches to this module.
Comment #20
neoxavier commentedHello,
is getStatus($human_name = TRUE) the API you refer to?
Comment #21
gdrupal commented@neoxavier I think it is... check the configuration_ui_config_info() in configuration_ui as an example on how to use it.
Comment #22
neoxavier commentedhere is the updated patch, I also re-base my branch so it commits to the latest HEAD.
Comment #23
gdrupal commentedI Think it's RTBC. ;)
Comment #24
gdrupal commented#22: configuration-cgtandcgnt-1808450-22.patch queued for re-testing.
Comment #25
gdrupal commentedCommitted
Comment #26
neoxavier commentedthanks :)