ajax callback breaks theming [#1805098]

As @thissideup noticed in #1307674: Notice: Undefined index: view_path in views_ajax(), line 26 of /sites/all/modules/views/includes/ajax.inc, and Jorrit noticed in #1730262: AJAX errors using Views mini pager, 'theme callback' => 'ajax_base_page_theme' was missing from our ajax menu callback, causing the themeing (css/js) to break. The font size of the whole page will change in some cases. Patch coming up.

Comment	File	Size	Author
#1	relation_select-ajax-callback-breaks-theming-1805098-1.patch	498 bytes	steveoliver

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

steveoliver CreditAttribution: steveoliver commented 6 October 2012 at 03:20

Status:

Needs work

» Reviewed & tested by the community

File	Size
relation_select-ajax-callback-breaks-theming-1805098-1.patch	498 bytes

From my conversation with him a few days, ago, Jorrit explains the theme_callback fix:

It is a very small change and it took a lot of time to find it :) the drupal ajax system is very extensive ... It communicates all css/js on the page to the ajax handler. The ajax handler then calculates the additional css/js that should be added. The problem was that without the patch, the ajax handler thinks that it should also add the css from the front theme. With $items['admin/relation-select/ajax'] this wouldn't have happened because the admin theme is used for admin/*, but the patch of mine is the way Drupal wants it. This is also better, because the user may edit a relation using the front theme. if the ajax handler would be on admin/, the reverse would happen: parts of the admin theme would be loaded.