Move node_test_node_access_all_uid variable to the state system
Move variable_get/_set/_delete to state()->get/set/delete

CommentFileSizeAuthor
#6 node_test_node_access_all_uid-1798868-6.patch1.83 KBAlbert Volkman
#4 node_test_node_access_all_uid-1798868-4.patch1.82 KBAlbert Volkman
#4 interdiff.txt2.58 KBAlbert Volkman
#2 node_test_node_access_all_uid-1798868-2.patch2.62 KBLuukyb
#1 node_test_node_access_all_uid-1798868.patch1.81 KBLuukyb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Luukyb’s picture

Luukyb CreditAttribution: Luukyb commented
FileSize
node_test_node_access_all_uid-1798868.patch1.81 KB
Luukyb’s picture

Luukyb CreditAttribution: Luukyb commented
FileSize
node_test_node_access_all_uid-1798868-2.patch2.62 KB

Added the namespace to the variable and the system_update function.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs review » Needs work
Issue tags: +State system

Thanks for the work.

There's no need for the system update as this variable is only ever used during testing. Also the state name should be
node_access_test.no_access_uid as it "belongs" to the node_access_test module.

+++ b/core/modules/node/tests/modules/node_access_test/node_access_test.moduleundefined
@@ -21,7 +21,7 @@ function node_access_test_node_grants($account, $op) {
+  if ($op == 'view' && $account->uid == state()->get('system.node_test_node_access_all_uid', 0)) {

Should be something like as ->get() does not support providing a default value

$no_access_uid = state()->get('node_test_access.no_access_uid') ?: 0;
if ($op == 'view' && $account->uid == $no_access_uid) {
Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Needs work » Needs review
FileSize
interdiff.txt2.58 KB
node_test_node_access_all_uid-1798868-4.patch1.82 KB

How's this?

Status: Needs review » Needs work

The last submitted patch, node_test_node_access_all_uid-1798868-4.patch, failed testing.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Needs work » Needs review
FileSize
node_test_node_access_all_uid-1798868-6.patch1.83 KB

Bleh.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

#6: node_test_node_access_all_uid-1798868-6.patch queued for re-testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

This is RTBC if it still applies.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.